helm: Add flag to disable CRD check for mass server-side apply

[jcpunk]

Please ensure your pull request adheres to the following guidelines:

• For first time contributors, read Submitting a pull request
• All code is covered by unit and/or runtime tests where feasible.
• All commits contain a well written commit description including a title,
  description and a Fixes: #XXX line if the commit addresses a particular
  GitHub issue.
• If your commit description contains a Fixes: <commit-id> tag, then
  please add the commit author[s] as reviewer[s] to this issue.
• All commits are signed off. See the section Developer’s Certificate of Origin
• Provide a title or release-note blurb suitable for the release notes.
• Are you a user of Cilium? Please add yourself to the Users doc
• Thanks for contributing!

When using a mass deployment tool (like kluctl) helm may be rendered locally before being submitted. In this two step process the CRDs are not yet deployed and thus the chart fails to render. The ability to pre-render the templates simplifies generation of the manifests for offline review or pass through kustomize. This sort of gitops workflow does all the renders in one step for review, then the apply in another step once the differences are approved.

helm: Add flag to disable CRD check for mass server-side apply

I'd like to see this in both 1.14 and 1.13 so I don't need to maintain a local fork of the 1.13 chart.

[qmonnet]

The changes look good from my side. I would appreciate more context/motivation in the commit description, if you don't mind a quick edit.

[qmonnet]

I'd like to see this in both 1.14 and 1.13

Should be in for 1.14, but I'm afraid this does not fall within the criteria we use for backports. I understand this may be frustrating, but it's hard to know where to draw the line if we start making exceptions 😕.

[kaworu]

/test

[jcpunk]

I'm not sure how to address the one failing job.

[kaworu]

I'm not sure how to address the one failing job.

It's not marked as Required, so no action is needed AFAIK.

[qmonnet]

This job was broken a few days ago, then fixed. You'd need to rebase your PR to have it run correctly, but as Alex said it's not necessary in the current case.