Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling out support for Single-Region, Multi-Region, Multi-AZ for EKS #26015

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Calling out support for Single-Region, Multi-Region, Multi-AZ for EKS #26015

merged 1 commit into from
Jun 20, 2023

Conversation

amitmavgupta
Copy link
Contributor

@amitmavgupta amitmavgupta commented Jun 8, 2023 •
edited by christarazi

No description provided.

@amitmavgupta amitmavgupta requested a review from a team as a code owner June 8, 2023 07:51
@maintainer-s-little-helper
Copy link

Commit 0073f9f008def18efcd72b167bc6ea7b4a8e7be8 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 8, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jun 8, 2023
@maintainer-s-little-helper
Copy link

Commits 0073f9f008def18efcd72b167bc6ea7b4a8e7be8, 15fb822b2abd48178da5292df5d2b6585582e7d7, 40ec234a6e4b38f7162f09eff806d5d1d896c1c0, eefae118718a3c04d533b0972e1d8b1f95c74a12 do not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

zacharysarah
zacharysarah requested changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amitmavgupta Some small formatting changes required, otherwise LGTM.

Be sure to add a release note.

Documentation/installation/requirements-eks.rst Outdated Show resolved Hide resolved
@maintainer-s-little-helper
Copy link

Commits 0073f9f008def18efcd72b167bc6ea7b4a8e7be8, 15fb822b2abd48178da5292df5d2b6585582e7d7, 40ec234a6e4b38f7162f09eff806d5d1d896c1c0, eefae118718a3c04d533b0972e1d8b1f95c74a12, 3d0f666caa96e9eba8ed5799245c3f3ef9ab3a9e do not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

christarazi
christarazi reviewed Jun 14, 2023
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Could you squash all of the commits into one commit? Also, please sign-off the commit by doing git commit --amend --signoff and if you'd like, reword the commit to say "Call out support for ..." so that it's a bit shorter.

@christarazi christarazi added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. integration/cloud Related to integration with cloud environments such as AKS, EKS, GKE, etc. labels Jun 14, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 14, 2023
@maintainer-s-little-helper
Copy link

Commits 0073f9f008def18efcd72b167bc6ea7b4a8e7be8, 15fb822b2abd48178da5292df5d2b6585582e7d7, 40ec234a6e4b38f7162f09eff806d5d1d896c1c0, eefae118718a3c04d533b0972e1d8b1f95c74a12 do not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper
Copy link

Commit 7fa1a8512641a93e91962c80363637006fc026b0 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 14, 2023
@maintainer-s-little-helper
Copy link

Commit bcca9c2406fd4763e14b74445425938df6946898 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 15, 2023
@maintainer-s-little-helper
Copy link

Commit bcca9c2406fd4763e14b74445425938df6946898 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 16, 2023
zacharysarah
zacharysarah approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

@christarazi
Copy link
Member

I am seeing two commits that are meant to be the same, could you please squash the two commits into one?

@amitmavgupta @joestringer
Call out support for Multi-AZ in EKS
d6c2b04 
Signed-off-by: amitmavgupta <115551423+amitmavgupta@users.noreply.github.com>
@joestringer joestringer merged commit 1198055 into cilium:main Jun 20, 2023
36 of 37 checks passed
@joestringer joestringer added needs-backport/1.11 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jun 20, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.5 Jun 20, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.12.12 Jun 20, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.11.19 Jun 20, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Needs backport from main in 1.11.19 Jun 20, 2023
@amitmavgupta amitmavgupta deleted the pr/ag/awsftrdocchange branch June 21, 2023 07:28
@nbusseneau nbusseneau mentioned this pull request Jun 22, 2023
Merged
10 tasks
@nbusseneau nbusseneau mentioned this pull request Jun 22, 2023
Merged
19 tasks
@nbusseneau nbusseneau added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jun 22, 2023
@joestringer joestringer mentioned this pull request Jun 28, 2023
Merged
@tklauser tklauser added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Jun 29, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.13 in 1.13.5 Jun 29, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport done to v1.12 in 1.12.12 Jun 29, 2023
@tklauser tklauser added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jun 29, 2023
@gentoo-root gentoo-root moved this from Backport pending to v1.13 to Backport done to v1.13 in 1.13.5 Jul 26, 2023
This was referenced Jul 26, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi left review comments

@zacharysarah zacharysarah zacharysarah approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. integration/cloud Related to integration with cloud environments such as AKS, EKS, GKE, etc. kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.12.12
Backport done to v1.12
1.13.5
Backport done to v1.13
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@amitmavgupta @christarazi @zacharysarah @tklauser @joestringer @nbusseneau