Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding an AWS architecture diagram for AWS FTR review #26016

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Adding an AWS architecture diagram for AWS FTR review #26016

merged 1 commit into from
Jun 20, 2023

Conversation

amitmavgupta
Copy link
Contributor

@amitmavgupta amitmavgupta commented Jun 8, 2023 •
edited by christarazi

No description provided.

@amitmavgupta amitmavgupta requested review from a team as code owners June 8, 2023 07:57
@maintainer-s-little-helper
Copy link

Commit f783264b7009bcc32c47f509b2e4f5134c8e3f27 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 8, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jun 8, 2023
zacharysarah
zacharysarah approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amitmavgupta 👋🏻 Please be sure to add a release note.

christarazi
christarazi reviewed Jun 14, 2023
View reviewed changes
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please signoff your commit by doing git commit --amend --signoff.

@christarazi christarazi added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. integration/cloud Related to integration with cloud environments such as AKS, EKS, GKE, etc. labels Jun 14, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jun 14, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jun 14, 2023
@amitmavgupta
Adding an AWS architecture diagram for AWS FTR review
9a4f9c0 
Signed-off-by: amitmavgupta <115551423+amitmavgupta@users.noreply.github.com>
@amitmavgupta
Copy link
Contributor Author

@christarazi could you kindly approve and merge? I have signed off the commit.

@christarazi
Copy link
Member

/test

@ti-mo ti-mo merged commit 93cc419 into cilium:main Jun 20, 2023
44 of 48 checks passed
@joestringer joestringer added needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jun 20, 2023
@amitmavgupta amitmavgupta deleted the pr/ag/awsftrimageadd branch June 21, 2023 07:28
@nbusseneau nbusseneau mentioned this pull request Jun 22, 2023
Merged
10 tasks
@nbusseneau nbusseneau mentioned this pull request Jun 22, 2023
Merged
19 tasks
@nbusseneau nbusseneau added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jun 22, 2023
@joestringer joestringer mentioned this pull request Jun 28, 2023
Merged
@tklauser tklauser added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.12 backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jun 29, 2023
This was referenced Jul 26, 2023
Merged
Merged
@joestringer
Copy link
Member

Hi @amitmavgupta , I know this feedback is late, but I'm wondering why this was needed if there was already an architecture diagram just a few lines down in the same document? Maybe this was a refresh and we should delete the second one?

https://docs.cilium.io/en/stable/installation/cni-chaining-aws-cni/

@amitmavgupta
Copy link
Contributor Author

@joestringer the architecture diagram was required to complete the AWS FTR which required us to have a reference architecture distinctly called out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharysarah zacharysarah zacharysarah approved these changes

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. integration/cloud Related to integration with cloud environments such as AKS, EKS, GKE, etc. kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@amitmavgupta @christarazi @joestringer @zacharysarah @tklauser @ti-mo @nbusseneau