bpf: nodeport: wire up trace struct for IPv6 RevDNAT #26047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the NAT path in to-overlay/to-netdev is included as tail_handle_nat_fwd_ipv6(), skip the hop through handle_nat_fwd_ipv6() and call the actual RevDNAT implementation straight away. This allows us to pass through a trace_ctx struct, so that the RevDNAT can return precise trace information from its CT lookup. The IPv4 path already does this, so we must have missed the boat at some point. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
added
sig/datapath
|
/test |
julianwiedmann
added
feature/ipv6
|
Looks like this cleanly cherry-picks back to v1.13, so let's apply it there as well. |
aspsk
approved these changes
Jun 9, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
(the one fail in the GH ginkgo tests is #25964) |
7 tasks
19 tasks
nbusseneau
added
backport-pending/1.13
tklauser
added
backport-done/1.13
gentoo-root
moved this from Needs backport from main
to Backport done to v1.13
in 1.13.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the NAT path in
to-overlay/to-netdevis included astail_handle_nat_fwd_ipv6(), skip the hop throughhandle_nat_fwd_ipv6()and call the actual RevDNAT implementation straight away.This allows us to pass through a
trace_ctxstruct, so that the RevDNAT can return precise trace information from its CT lookup.The IPv4 path already does this, so we must have missed the boat at some point.