Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gateway-api: Remove unused function check #26058

Merged
merged 1 commit into from
Jun 9, 2023
Merged

gateway-api: Remove unused function check #26058

merged 1 commit into from
Jun 9, 2023

Conversation

ferozsalam
Copy link
Contributor

@ferozsalam ferozsalam commented Jun 9, 2023 •
edited by sayboras

The linter is complaining about isReferenceAllowed not being used as a result of cd826fd

The isReferenceAllowed check is now defined in operator/pkg/gateway-api/helpers/referencegrants.go, I have removed the unused version.

@ferozsalam
Remove unused check
e676ae1 
The isReferenceAllowed check is now defined in
`operator/pkg/gateway-api/helpers/referencegrants.go`

Signed-off-by: Feroz Salam <feroz.salam@isovalent.com>
@ferozsalam ferozsalam added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. area/servicemesh GH issues or PRs regarding servicemesh labels Jun 9, 2023
@ferozsalam ferozsalam requested a review from a team as a code owner June 9, 2023 03:33
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Jun 9, 2023
@sayboras
Copy link
Member

sayboras commented Jun 9, 2023

/test

@sayboras
Copy link
Member

sayboras commented Jun 9, 2023

/test-backport-1.13

michi-covalent
michi-covalent approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😇

@sayboras sayboras changed the title Remove unused check gateway-api: Remove unused check Jun 9, 2023
@sayboras sayboras changed the title gateway-api: Remove unused check gateway-api: Remove unused function check Jun 9, 2023
@michi-covalent michi-covalent mentioned this pull request Jun 9, 2023
Closed
44 tasks
@sayboras
Copy link
Member

sayboras commented Jun 9, 2023

Failed tests are due to wrong comand used, all requried tests are passed, reviews are in.

ci-l4lb-1.13 is not related to this change. Marking this ready to merge.

@sayboras sayboras added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 9, 2023
@michi-covalent michi-covalent merged commit 445ff87 into v1.13 Jun 9, 2023
66 of 72 checks passed
@michi-covalent michi-covalent deleted the pr/remove-unused-function branch June 9, 2023 07:25
@qmonnet qmonnet mentioned this pull request Jun 9, 2023
Closed
This was referenced Jun 9, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

@meyskens meyskens Awaiting requested review from meyskens

Assignees
No one assigned
Labels
area/servicemesh GH issues or PRs regarding servicemesh backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ferozsalam @sayboras @michi-covalent