Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.13] Backport print-chart-version script for dev Helm chart push #26087

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

joestringer
Copy link
Member

@joestringer joestringer commented Jun 9, 2023

[ upstream commit d90803c ]
[ upstream commit 2c367de ]
[ Backporter's notes:

  • Removed github workflow. Workflow operates from main branch.
  • Applied /usr/bin/env hunk to the script (was treewide). ]

Related: #25205

$ for pr in 25205; do contrib/backporting/set-labels.py $pr done v1.13; done

[ upstream commit d90803c ]
[ upstream commit 2c367de ]
[ Backporter's notes:
  - Removed github workflow. Workflow operates from main branch.
  - Applied /usr/bin/env hunk to the script (was treewide). ]

Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer requested a review from a team as a code owner June 9, 2023 17:21
@joestringer joestringer added the release-note/misc This PR makes changes that have no direct user impact. label Jun 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Jun 9, 2023
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's get #26086 merged first. otherwise the push chart workflow will start failing on v1.13 branch.

edit: oh it's the other way around. this one needs to go first so that the script exists 👀

@michi-covalent
Copy link
Contributor

✅ confirmed the chart version here: https://github.com/cilium/cilium/actions/runs/5224577019 (1.13.3-dev.35-pr-joe-version-script-v1-13-e76d38d1d6)

https://quay.io/repository/cilium-charts-dev/cilium?tab=tags

no need for the full CI run. let's just wait for the basic CI to finish before merging.

@michi-covalent michi-covalent merged commit 843403d into v1.13 Jun 9, 2023
40 checks passed
@michi-covalent michi-covalent deleted the pr/joe/version-script-v1.13 branch June 9, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants