-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: reword incorrect L7 policy description #26092
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix for the description of the GET /public
sounds good.
For the dollars, I'm not sure this is a mistake, maybe just something that's missing documentation. I can see some other examples using it, including in tests (pkg/policy/api/utils_test.go
). My guess is that it means the path should match until the end, and not just be a prefix. So please let's clarify whether this is actually something that needs an update before removing these $
.
From a quick look at the doc (https://docs.cilium.io/en/latest/security/policy/language/#layer-7-examples):
So probably nothing to change on that side. |
Fixing incorrect description of the GET /public policy in the L7 section. Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Thanks @qmonnet -- I removed those changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
Remove the extra $ characters in the paths (I didn't see this documented anywhere, so I am assuming it might be a left over from previous versions?).
Also, I am fixing incorrect description of the GET /public policy in the L7 section.