Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugtool: add map dumps and events for all lb4/6 v3 backends #26108

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

ti-mo
Copy link
Contributor

@ti-mo ti-mo commented Jun 12, 2023

Bugtool is missing dumps and events for lb4/6 v3 backends.

I'm using this PR to get some more output for #26062.

Dump maps and events for all lb4/6 v3 backends

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 12, 2023
@ti-mo ti-mo added release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jun 12, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jun 12, 2023
@ti-mo
Copy link
Contributor Author

ti-mo commented Jun 12, 2023

/test

@ti-mo ti-mo changed the title WIP: bugtool: add map dumps and events for all lb4/6 v3 backends bugtool: add map dumps and events for all lb4/6 v3 backends Jun 13, 2023
Signed-off-by: Timo Beckers <timo@isovalent.com>
Signed-off-by: Timo Beckers <timo@isovalent.com>
@ti-mo
Copy link
Contributor Author

ti-mo commented Jun 13, 2023

/test

@ti-mo ti-mo marked this pull request as ready for review June 13, 2023 08:17
@ti-mo ti-mo requested review from a team as code owners June 13, 2023 08:17
@ti-mo ti-mo requested review from rgo3 and asauber June 13, 2023 08:17
@mhofstetter mhofstetter added the area/bugtool Impacts gathering of data for debugging purposes. label Jun 13, 2023
@mhofstetter
Copy link
Member

@ti-mo is this really of type release-note/bug?

@ti-mo
Copy link
Contributor Author

ti-mo commented Jun 13, 2023

@ti-mo is this really of type release-note/bug?

I guess not, though it addresses an oversight in a released version of Cilium. Does it make a difference?

@mhofstetter
Copy link
Member

I guess not, though it addresses an oversight in a released version of Cilium. Does it make a difference?

not really - even though IMO it's more kind of an enhancement/cleanup (of something that got missed) - and it's not actually fixing a bug. otherwise it gets mentioned as fixed bug in the release notes? i would label it as release-note/misc

@ti-mo ti-mo added release-note/misc This PR makes changes that have no direct user impact. and removed release-note/bug This PR fixes an issue in a previous release of Cilium. labels Jun 13, 2023
@ti-mo
Copy link
Contributor Author

ti-mo commented Jun 13, 2023

/test-runtime

Job 'Cilium-PR-K8s-1.26-kernel-net-next' hit: #25958 (92.28% similarity)

@ti-mo
Copy link
Contributor Author

ti-mo commented Jun 14, 2023

/test-1.26-net-next

1 similar comment
@ti-mo
Copy link
Contributor Author

ti-mo commented Jun 14, 2023

/test-1.26-net-next

@ti-mo ti-mo merged commit f68f0d4 into cilium:main Jun 14, 2023
63 of 65 checks passed
@ti-mo ti-mo deleted the tb/bugtool-lb-v3 branch June 14, 2023 18:42
@nbusseneau nbusseneau mentioned this pull request Jun 22, 2023
19 tasks
@nbusseneau nbusseneau added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jun 22, 2023
@tklauser tklauser added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bugtool Impacts gathering of data for debugging purposes. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants