Add cilium bpf nodeid list to bugtool and print nodeid in hex in ipcache dump #26130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brb
added
area/encryption
gandro
approved these changes
Jun 12, 2023
pchaigno
approved these changes
Jun 12, 2023
pchaigno
added
the
area/bugtool
brb
changed the title
|
Sorry, pushed to the same PR other change (dump the nodeid in hex in the IPcache output) |
aspsk
approved these changes
Jun 12, 2023
pchaigno
reviewed
Jun 12, 2023
pchaigno
added
needs-backport/1.11
needs-backport/1.13
|
Marking for backports everywhere. I think the risk is very low given it only affects CLI and bugtool and it's fairly trivial. I also don't expect any conflicts for the CLI changes. |
asauber
approved these changes
Jun 14, 2023
To help to detect when IPcache is out of sync with locally stored Node IDs. Signed-off-by: Martynas Pumputis <m@lambda.lt>
The Node ID is used in SKB mark used by XFRM policies. The latter print it in hex. So, let's reduce a mental strain by a bit when debugging IPsec issues. Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb
force-pushed
the
pr/brb/bugtool-bpf-nodeid-list
branch
from
224765d
to
6cd0413
Compare
pchaigno
approved these changes
Jun 19, 2023
|
This isn't covered by end-to-end CI tests. It's reviewed and all other tests passed so marking ready to merge. |
pchaigno
added
the
ready-to-merge
7 tasks
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.11
in 1.11.18
10 tasks
19 tasks
nbusseneau
added
backport-pending/1.13
tklauser
added
backport-done/1.11
maintainer-s-little-helper
bot
moved this from Backport pending to v1.11
to Backport done to v1.11
in 1.11.18
tklauser
added
backport-done/1.12
gentoo-root
moved this from Needs backport from main
to Backport done to v1.11
in 1.11.19
gentoo-root
moved this from Needs backport from main
to Backport done to v1.12
in 1.12.12
This was referenced Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To help to detect when IPcache is out of sync with locally stored Node IDs.