Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport (v1.13): docs: Promote Deny Policies out of Beta #26147

Merged

Conversation

nathanjsweet
Copy link
Member

No description provided.

Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
@nathanjsweet nathanjsweet added the release-note/misc This PR makes changes that have no direct user impact. label Jun 13, 2023
@nathanjsweet nathanjsweet requested a review from a team as a code owner June 13, 2023 03:24
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Jun 13, 2023
@nathanjsweet nathanjsweet changed the title docs: Promote Deny Policies out of Beta backport (v1.13): docs: Promote Deny Policies out of Beta Jun 13, 2023
@michi-covalent
Copy link
Contributor

probably missing some context, but do we usually change the status of a feature in a patch release?

@michi-covalent michi-covalent merged commit 5f42c00 into v1.13 Jun 13, 2023
35 checks passed
@michi-covalent michi-covalent deleted the pr/nathanjsweet/promote-deny-policies-to-stable-1-13 branch June 13, 2023 22:54
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michi-covalent this partly comes out of my discussion here and around the release note: #25491 (comment) .

I don't think we've strictly documented the bar this should meet or the process to remove features from stable. Practically speaking the quality of the feature with recent bugfixes has been raised to the level that we believe to be "stable" - no known outstanding issues for instance, and users are already running the feature in production. So if we're happy to mark it as stable on the latest branch, all other branches logically would also follow suit.

In general I'm not the biggest fan of retrospectively marking features like this, partly because tracking which micro release brought "stability" is difficult to track, and partly because it encourages a deployment lifecycle where users can stay on older versions and still get newer features. But in this particular case, given the feature maturity that has been met and the lack of documented process to guide us, I'm open to making an exception here.

I also recognize that Nate did a lot of work on improving the policy engine to get this feature to this point, and I think it's worth celebrating his contributions through a well-advertised release note.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants