Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon: don't allow egress gateway with KV store identity allocation #26189

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

jibi
Copy link
Member

@jibi jibi commented Jun 13, 2023

as the egress gateway feature would not be supported

as the egress gateway feature would not be supported

Signed-off-by: Gilberto Bertin <jibi@cilium.io>
@jibi jibi added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. feature/egress-gateway Impacts the egress IP gateway feature. sig/agent Cilium agent related. needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jun 13, 2023
@jibi jibi requested a review from aanm June 13, 2023 15:32
@jibi jibi requested a review from a team as a code owner June 13, 2023 15:32
@jibi
Copy link
Member Author

jibi commented Jun 13, 2023

/test

@jibi
Copy link
Member Author

jibi commented Jun 13, 2023

/test-runtime

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 14, 2023
@jibi jibi merged commit 7f7a285 into main Jun 14, 2023
66 checks passed
@jibi jibi deleted the pr/jibi/egressgw-kvstore branch June 14, 2023 10:10
@nbusseneau nbusseneau mentioned this pull request Jun 22, 2023
10 tasks
@nbusseneau nbusseneau mentioned this pull request Jun 22, 2023
19 tasks
@nbusseneau nbusseneau added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jun 22, 2023
@tklauser tklauser added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.12 backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. feature/egress-gateway Impacts the egress IP gateway feature. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/agent Cilium agent related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants