bpf: ct: fix CT-based packet tracing for IPv6 #26476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While refactoring the CT lookup helpers, I fat-fingered the order of parameters in the ct_lookup6() helper (which is used by eg. bpf_lxc). But as both parameters are primarily used for tracing policy, this didn't completely break things - we just don't get the expected trace output for packets, and have problems detecting closed / reopened connections. Fix the parameters up to make things work again. Fixes: eee902f ("bpf: conntrack: introduce an optimized CT lookup for LB") Reported-by: Marco Iorio <marco.iorio@isovalent.com> Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
added
kind/bug
2 tasks
|
/test |
borkmann
approved these changes
Jun 26, 2023
borkmann
added
the
release-blocker/1.13
jschwinger233
approved these changes
Jun 26, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
tklauser
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.13
in 1.13.5
tklauser
added
backport-done/1.13
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While refactoring the CT lookup helpers, I fat-fingered the order of parameters in the ct_lookup6() helper (which is used by eg. bpf_lxc). But as both parameters are primarily used for tracing policy, this didn't completely break things - we just don't get the expected trace output for packets, and have problems detecting closed / reopened connections.
Fix the parameters up to make things work again.
Fixes: eee902f ("bpf: conntrack: introduce an optimized CT lookup for LB")
Fixes: #26418
Reported-by: Marco Iorio marco.iorio@isovalent.com