Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.13 Backports 2023-06-28 #26528

Merged
merged 3 commits into from
Jun 28, 2023
Merged

v1.13 Backports 2023-06-28 #26528

merged 3 commits into from
Jun 28, 2023

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Jun 28, 2023

PRs skipped due to conflicts:

Once this PR is merged, you can update the PR labels via:

for pr in 22670 26476 26458; do contrib/backporting/set-labels.py $pr done 1.13; done

or with

make add-labels BRANCH=v1.13 ISSUES=22670,26476,26458

oliver-ni and others added 3 commits June 28, 2023 11:01
[ upstream commit b8786b3 ]

This commit is to add loadBalancerIP and loadBalancerClass for
shared Ingress service. Kindly note the below points:

- loadbalancerIP feature is depending on cloud provider controller
- loadBalancerClass is only supported for k8s 1.24 and later.

Signed-off-by: Oliver Ni <oliver.ni@gmail.com>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
[ upstream commit ee5f473 ]

While refactoring the CT lookup helpers, I fat-fingered the order of
parameters in the ct_lookup6() helper (which is used by eg. bpf_lxc).
But as both parameters are primarily used for tracing policy, this didn't
completely break things - we just don't get the expected trace output for
packets, and have problems detecting closed / reopened connections.

Fix the parameters up to make things work again.

[ backporter's note: encountered merge conflict, modified to only switch
  l4_off and action in the __ct_lookup6 call. ]

Fixes: eee902f ("bpf: conntrack: introduce an optimized CT lookup for LB")
Reported-by: Marco Iorio <marco.iorio@isovalent.com>
Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
[ upstream commit fd3814e ]

before the fix 2 content headers are not returned

```release-note
Fix: Return "Content-Type" and "X-Content-Type-Options" headers from  Health Check Node Port
```

Signed-off-by: Cezary Zawadka <czawadka@google.com>
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
@tklauser tklauser added kind/backports This PR provides functionality previously merged into master. backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. labels Jun 28, 2023
@tklauser tklauser requested review from squeed and borkmann June 28, 2023 11:19
@tklauser tklauser marked this pull request as ready for review June 28, 2023 11:20
@tklauser tklauser requested a review from a team as a code owner June 28, 2023 11:20
@tklauser
Copy link
Member Author

tklauser commented Jun 28, 2023

/test-backport-1.13

Job 'Cilium-PR-K8s-1.25-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks E/W loadbalancing (ClusterIP, NodePort from inside cluster, etc) Tests NodePort inside cluster (kube-proxy) with externalTrafficPolicy=Local

Failure Output

FAIL: Request from k8s1 to service tftp://[fd04::12]:32051/hello failed

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.25-kernel-4.19/766/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.25-kernel-4.19 so I can create one.

Then please upload the Jenkins artifacts to that issue.

Copy link
Member

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ta Tobias for resolving the conflict!

@tklauser
Copy link
Member Author

/test-1.25-4.19

@tklauser tklauser merged commit 69a8c9e into v1.13 Jun 28, 2023
62 checks passed
@tklauser tklauser deleted the pr/v1.13-backport-2023-06-28 branch June 28, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants