Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.13 Backports 2023-07-05 #26637

Merged
merged 1 commit into from
Jul 5, 2023
Merged

v1.13 Backports 2023-07-05 #26637

merged 1 commit into from
Jul 5, 2023

Conversation

joamaki
Copy link
Contributor

@joamaki joamaki commented Jul 5, 2023 •
edited by tklauser

Once this PR is merged, you can update the PR labels via:

for pr in 26139; do contrib/backporting/set-labels.py $pr done 1.13; done

or with

make add-labels BRANCH=v1.13 ISSUES=26139

@PhilipSchmid @joamaki
doc: Documented incompatibility of EgressGW and kvstore
7f1c363 
[ upstream commit dcc0a0e ]

Signed-off-by: Philip Schmid <philip.schmid@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
@joamaki joamaki added kind/backports This PR provides functionality previously merged into master. backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. labels Jul 5, 2023
@joamaki joamaki requested a review from PhilipSchmid July 5, 2023 08:33
PhilipSchmid
PhilipSchmid approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@PhilipSchmid PhilipSchmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@joamaki joamaki marked this pull request as ready for review July 5, 2023 13:42
@joamaki joamaki requested a review from a team as a code owner July 5, 2023 13:42
@joamaki joamaki added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 5, 2023
@joamaki
Copy link
Contributor Author

joamaki commented Jul 5, 2023

No need for full tests since this is a documentation change. Marking ready-to-merge.

@squeed squeed merged commit 28c188c into v1.13 Jul 5, 2023
35 checks passed
@squeed squeed deleted the pr/v1.13-backport-2023-07-05 branch July 5, 2023 14:14
@gentoo-root gentoo-root mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

@PhilipSchmid PhilipSchmid PhilipSchmid approved these changes

Assignees
No one assigned
Labels
backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joamaki @squeed @PhilipSchmid