Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: uniform the final sysdump names in conformance clustermesh #26686

Merged

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Jul 7, 2023

Make sure that the name of both sysdumps gathered at the end of the tests in case of failures match the same structure.

Make sure that the name of both sysdumps gathered at the end of the
tests in case of failures match the same structure.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 added area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/ci This PR makes changes to the CI. labels Jul 7, 2023
@giorio94 giorio94 requested review from a team as code owners July 7, 2023 08:09
@giorio94 giorio94 requested review from aanm and nebril July 7, 2023 08:09
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Jul 7, 2023
@giorio94
Copy link
Member Author

giorio94 commented Jul 7, 2023

/ci-multicluster

@giorio94
Copy link
Member Author

giorio94 commented Jul 7, 2023

The ClusterMesh workflow completed successfully (the previous run failed due to a known flake, confirming at the same time that the sysdumps were generated correctly). Reviews are in, marking as ready to merge.

@giorio94 giorio94 added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 7, 2023
@borkmann borkmann merged commit cbcaa18 into v1.13 Jul 7, 2023
52 checks passed
@borkmann borkmann deleted the pr/giorio94/conformance-clustermesh-uniform-sysdump-name branch July 7, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants