Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Pick up PyYAML 6.0.1 #26883

Merged
merged 1 commit into from
Jul 18, 2023
Merged

docs: Pick up PyYAML 6.0.1 #26883

merged 1 commit into from
Jul 18, 2023

Conversation

michi-covalent
Copy link
Contributor

Revert commit 04d48fe, and pick up PyYAML 6.0.1.

Fixes: #26873

@michi-covalent
docs: Pick up PyYAML 6.0.1
c92d71e 
Revert commit 04d48fe, and pick up PyYAML 6.0.1.

Fixes: #26873

Signed-off-by: Michi Mutsuzaki <michi@isovalent.com>
@michi-covalent michi-covalent requested a review from a team as a code owner July 18, 2023 00:59
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 18, 2023
@michi-covalent michi-covalent added the release-note/misc This PR makes changes that have no direct user impact. label Jul 18, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 18, 2023
@michi-covalent
Copy link
Contributor Author

ran make -C Documentation builder-image locally to verify that it fixes #26873

@michi-covalent
Copy link
Contributor Author

/test

learnitall
learnitall approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@gandro
Copy link
Member

gandro commented Jul 18, 2023

Adding needs-backport labels based on the commit which is fixed.

@gandro gandro added needs-backport/1.11 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 18, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.12.12 Jul 18, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.0 Jul 18, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.11.19 Jul 18, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.5 Jul 18, 2023
@gandro gandro removed the request for review from qmonnet July 18, 2023 07:27
@gandro
Copy link
Member

gandro commented Jul 18, 2023

Documentation and Travis are green. Let's merge this to fix CI.

@gandro gandro added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 18, 2023
@gandro gandro merged commit e06e70e into main Jul 18, 2023
51 checks passed
@gandro gandro deleted the pr/michi/revert branch July 18, 2023 07:29
@gandro gandro mentioned this pull request Jul 18, 2023
Closed
9 tasks
@gandro gandro added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jul 18, 2023
@gandro gandro mentioned this pull request Jul 18, 2023
Merged
9 tasks
@gandro gandro added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Jul 19, 2023
@gandro gandro mentioned this pull request Jul 19, 2023
Merged
5 tasks
@gandro gandro added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jul 19, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport done to v1.14 in 1.14.0 Jul 19, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.13 in 1.13.5 Jul 19, 2023
@gandro gandro mentioned this pull request Jul 19, 2023
Merged
3 tasks
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.12 in 1.12.12 Jul 19, 2023
@gandro gandro mentioned this pull request Jul 19, 2023
Merged
3 tasks
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.11 in 1.11.19 Jul 19, 2023
@gandro gandro added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Jul 19, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.12 to Backport done to v1.12 in 1.12.12 Jul 19, 2023
@gandro gandro added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.11 backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jul 19, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.13 to Backport done to v1.13 in 1.13.5 Jul 19, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.11 to Backport done to v1.11 in 1.11.19 Jul 19, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.11 to Backport done to v1.11 in 1.11.19 Jul 19, 2023
@gandro gandro mentioned this pull request Jul 20, 2023
Closed
This was referenced Jul 26, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@learnitall learnitall learnitall approved these changes

Assignees
No one assigned
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.11.19
Backport done to v1.11
1.12.12
Backport done to v1.12
1.13.5
Backport done to v1.13
1.14.0
Backport done to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: Travis ERROR: Could not find a version that satisfies the requirement PyYAML==6.0
3 participants
@michi-covalent @gandro @learnitall