v1.13 Backports 2023-07-19 #26915
Merged
v1.13 Backports 2023-07-19 #26915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit 04d48fe ] Use this workaround until the issue gets fixed: yaml/pyyaml#601 (comment) Signed-off-by: Michi Mutsuzaki <michi@isovalent.com> Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
[ upstream commit 0bf7cc5 ] Only configure GetClientCertificate if client keypair is configured, allowing servers to Request ClientCertificates without requiring them. In docs for `GetClientCertificate` it specifies: > GetClientCertificate must return a non-nil Certificate. If > Certificate.Certificate is empty then no certificate will be sent to the > server. If a nil certificate is sent when the server requests a client certificate, the client will return an error. Instead, only configure GetClientCertificate if certificates are provided and the server may choose to how to handle the lack of a client certificate. This is needed primarily for when the server is using RequestClientCert, which requests a certificate, but does not require the client to send one. Previously, you would see this log message: ``` transport: authentication handshake failed: mTLS client certificate requested, but not provided ``` Now, if a server requires a client certificate it should reject the TLS connection and the client will receive the error from the server. Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com> Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
[ upstream commit 57249b1 ] Signed-off-by: toVersus <toversus2357@gmail.com> Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
[ upstream commit b10d096 ] Otherwise, when the IPv6 is disabled, the check-log-errors fails with: Error while inserting service in LB map" error="Unable to upsert service [fd00:10:96::8f2f]:8080 as IPv6 is disabled" k8sNamespace=cilium-test k8sSvcName=echo-same-node Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
added
kind/backports
|
/test-backport-1.13 Edit: |
|
|
/test-1.26-net-next |
chancez
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, you can update the PR labels via:
or with