Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixing blank k8sPodName in endpoint logger #26964

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

vakalapa
Copy link
Contributor

@vakalapa vakalapa commented Jul 20, 2023

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

When a new endpoint is created, a logger is created with it. This logger is populated with pod detail fields. Initially the endpoint is not populated with pod name or ip addr details, so, the logger fields are populated with empty fields. These fields are never updated.

This PR calls update logger to re-populate pod fields.

Fixes: #22242

<!-- Enter the release note text here if needed or remove this section! -->

@vakalapa vakalapa requested a review from a team as a code owner July 20, 2023 17:12
@vakalapa vakalapa requested a review from aditighag July 20, 2023 17:12
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 20, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jul 20, 2023
@maintainer-s-little-helper
Copy link

Commit d70b38d8418ab2f502a36eed31fd6fcf7195a065 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jul 20, 2023
@maintainer-s-little-helper
Copy link

Commits d70b38d8418ab2f502a36eed31fd6fcf7195a065, d697c2581e933495c64d2ca28b5d3cc40d3b8e67 do not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

1 similar comment
@maintainer-s-little-helper
Copy link

Commits d70b38d8418ab2f502a36eed31fd6fcf7195a065, d697c2581e933495c64d2ca28b5d3cc40d3b8e67 do not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@aditighag aditighag requested review from christarazi and removed request for aditighag July 21, 2023 23:00
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jul 24, 2023
Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Could you squash the commits into one?

@christarazi christarazi added area/daemon Impacts operation of the Cilium daemon. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. release-note/misc This PR makes changes that have no direct user impact. labels Jul 24, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jul 24, 2023
@christarazi christarazi added the kind/enhancement This would improve or streamline existing functionality. label Jul 24, 2023
@maintainer-s-little-helper
Copy link

Commit 559d679ec4c8f7ef5924c16b2512ae2eeca48063 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jul 24, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Jul 24, 2023
@vakalapa
Copy link
Contributor Author

@christarazi Done, merged the commits into one.

Signed-off-by: vakr <vakr@microsoft.com>
@christarazi
Copy link
Member

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jul 25, 2023
@youngnick
Copy link
Contributor

youngnick commented Jul 26, 2023

Looks like this hit #26014, rerunning

/test ci-aks

@youngnick
Copy link
Contributor

/test

@youngnick
Copy link
Contributor

youngnick commented Jul 26, 2023

Okay, this time there seems to have been a problem with Cilium container images coming across multiple builds, maybe a pull error? Logs were unclear. Going to try again.

/test

Edit: Oh, okay, seems like Ariane doesn't like commentary, just actions.

@youngnick
Copy link
Contributor

/test

@youngnick youngnick merged commit 8a3148a into cilium:main Jul 26, 2023
69 checks passed
@tklauser tklauser added the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label Aug 11, 2023
@tklauser tklauser mentioned this pull request Aug 22, 2023
22 tasks
@tklauser tklauser added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Aug 22, 2023
@joestringer joestringer added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/daemon Impacts operation of the Cilium daemon. area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. kind/community-contribution This was a contribution made by a community member. kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sometimes logs have a blank k8sPodName
5 participants