-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fixing blank k8sPodName in endpoint logger #26964
Conversation
Commit d70b38d8418ab2f502a36eed31fd6fcf7195a065 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Commits d70b38d8418ab2f502a36eed31fd6fcf7195a065, d697c2581e933495c64d2ca28b5d3cc40d3b8e67 do not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
1 similar comment
Commits d70b38d8418ab2f502a36eed31fd6fcf7195a065, d697c2581e933495c64d2ca28b5d3cc40d3b8e67 do not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
c838c41
to
74b6bce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Could you squash the commits into one?
Commit 559d679ec4c8f7ef5924c16b2512ae2eeca48063 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
559d679
to
39c8b08
Compare
@christarazi Done, merged the commits into one. |
Signed-off-by: vakr <vakr@microsoft.com>
39c8b08
to
e7ce88a
Compare
/test |
Looks like this hit #26014, rerunning /test ci-aks |
/test |
Okay, this time there seems to have been a problem with Cilium container images coming across multiple builds, maybe a pull error? Logs were unclear. Going to try again. /test Edit: Oh, okay, seems like Ariane doesn't like commentary, just actions. |
/test |
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Fixes: <commit-id>
tag, thenplease add the commit author[s] as reviewer[s] to this issue.
When a new endpoint is created, a logger is created with it. This logger is populated with pod detail fields. Initially the endpoint is not populated with pod name or ip addr details, so, the logger fields are populated with empty fields. These fields are never updated.
This PR calls update logger to re-populate pod fields.
Fixes: #22242