ingress: Delay secret sync if not available #26988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if the TLS secret is not available by the time the Ingress object is created, the creation event will be filtered out based on in-memory list of watched secrets. This commit is to make sure that we still add secret name to watch list, so that creation event will trigger the sync accordingly. Testing is done as per below: ``` $ curl -k -v https://bookinfo.cilium.rocks/details/1 * Trying 10.104.207.106:443... * Connected to bookinfo.cilium.rocks (10.104.207.106) port 443 (#0) * ALPN: offers h2,http/1.1 * TLSv1.3 (OUT), TLS handshake, Client hello (1): * Recv failure: Connection reset by peer * OpenSSL SSL_connect: Connection reset by peer in connection to bookinfo.cilium.rocks:443 * Closing connection 0 curl: (35) Recv failure: Connection reset by peer $ kubectl create secret tls demo-cert --key=_.cilium.rocks/key.pem --cert=_.cilium.rocks/cert.pem secret/demo-cert created $ curl -k https://bookinfo.cilium.rocks/details/1 {"id":1,"author":"William Shakespeare","year":1595,"type":"paperback","pages":200,"publisher":"PublisherA","language":"English","ISBN-10":"1234567890","ISBN-13":"123-1234567890"} ``` Signed-off-by: Tam Mach <tam.mach@cilium.io>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
sayboras
added
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
sayboras
added
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
|
/test |
|
Review is done by the required team, and CI is all good, merging this one in. |
sayboras
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.13
in 1.13.5
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.12
in 1.12.12
sayboras
added
backport-pending/1.14
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.0
sayboras
added
backport-done/1.12
maintainer-s-little-helper
bot
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.0
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.5
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.5
maintainer-s-little-helper
bot
moved this from Backport pending to v1.12
to Backport done to v1.12
in 1.12.12
This was referenced Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the TLS secret is not available by the time the Ingress object is created, the creation event will be filtered out based on in-memory list of watched secrets. This commit is to make sure that we still add secret name to watch list, so that creation event will trigger the sync accordingly.
Testing is done as per below: