bpf: l4lb: fix IPIP health-check path #27015
Merged
+218
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianwiedmann
added
kind/bug
julianwiedmann
force-pushed
the
1.15-bpf-l4lb-ipip-health-check
branch
2 times, most recently
from
9edf7f0 to
83f009e
Compare
|
/test |
julianwiedmann
force-pushed
the
1.15-bpf-l4lb-ipip-health-check
branch
from
83f009e to
15d1712
Compare
|
/test |
If handle_nat_fwd() expands into a tail-call (eg. because both ENABLE_IPV4 and ENABLE_IPV6 are set), control doesn't return to the main to-netdev program. Thus the packet path never passes through the L4LB health-check processing. This is a regression caused by 54a8631 - previously, we would skip the NAT check in a full-DSR config (and the L4LB IPIP mode is always full-DSR). Fix it by pulling the health-check section up, so that it gets applied before walking down the NAT path. Also add a minimal integration test to cover the expected encapsulation behaviour. Fixes: 54a8631 ("bpf: nodeport: handle revDNAT for local backends at to-netdev/to-overlay") Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
force-pushed
the
1.15-bpf-l4lb-ipip-health-check
branch
from
15d1712 to
45ed4ee
Compare
|
tiny update to the test, to bring it more in-line with how the feature works |
|
/test |
|
For some context: #14610 |
maintainer-s-little-helper
bot
added
the
ready-to-merge
sayboras
added
the
backport-pending/1.14
sayboras
added
backport-done/1.14
This was referenced Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
handle_nat_fwd()expands into a tail-call (eg. because both ENABLE_IPV4 and ENABLE_IPV6 are set), control doesn't return to the mainto-netdevprogram. Thus the packet path never passes through the L4LB health-check processing.This is a regression caused by 54a8631 - previously, we would skip the NAT check in a full-DSR config (and the L4LB IPIP mode is always full-DSR).
Fix it by pulling the health-check section up, so that it gets applied before walking down the NAT path. Also add a minimal integration test to cover the expected encapsulation behaviour.
Fixes: 54a8631 ("bpf: nodeport: handle revDNAT for local backends at to-netdev/to-overlay")