[1.13] Add documentation about bpf-clock breakage #27048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
margamanterola
added
the
release-note/misc
maintainer-s-little-helper
bot
added
backport/1.13
margamanterola
force-pushed
the
bpf-clock-doc-1.13
branch
from
53c0f77
to
63209c7
Compare
margamanterola
removed
kind/backports
margamanterola
force-pushed
the
bpf-clock-doc-1.13
branch
from
63209c7
to
099c150
Compare
margamanterola
added
the
area/documentation
pchaigno
approved these changes
Jul 25, 2023
pchaigno
added
ready-to-merge
aanm
requested changes
Jul 25, 2023
Documentation/operations/upgrade.rst
Outdated
Comment on lines
453
to
455
| * ``bpfClockProbe`` has been set to ``false`` everywhere to avoid interrupting | ||
| existing connections. It can still be manually set to ``true`` if the | ||
| ``bpf-clock-probe`` behavior is desired. |
There was a problem hiding this comment.
I'm confused about this. bpfClockProbe is the helm option, shouldn't it be "bpfClockProbe behavior is desired."?
There was a problem hiding this comment.
I think it should actually be "if the BPF clock probe behavior is desired" (i.e. no code text, this is talking about the underlying behavior), what do you think?
There was a problem hiding this comment.
Reworded as mentioned. PTAL
aanm
removed
the
ready-to-merge
margamanterola
force-pushed
the
bpf-clock-doc-1.13
branch
from
099c150
to
5c81e06
Compare
joestringer
reviewed
Jul 25, 2023
margamanterola
force-pushed
the
bpf-clock-doc-1.13
branch
from
5c81e06
to
9eb76a1
Compare
We've disabled bpfClockProbe everywhere with cilium#26981 and backports. Document that existing connections may be interrupted when upgrading to 1.13.4, the only release to ship with this enabled. On the other hand, they may linger for too long if upgrading from that release to one where bpf-clock-probe is no longer enabled. Signed-off-by: Margarita Manterola <marga@isovalent.com>
margamanterola
force-pushed
the
bpf-clock-doc-1.13
branch
from
9eb76a1
to
52e580e
Compare
youngnick
approved these changes
Jul 26, 2023
aanm
approved these changes
Jul 26, 2023
nbusseneau
added
kind/backports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've disabled bpfClockProbe everywhere with #26981 and backports. Document that long lived connections will be interrupted when upgrading to and from 1.13.4, the only release to ship with this enabled.