Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Simplify clustermesh example #27172

Merged
merged 1 commit into from
Aug 2, 2023
Merged

docs: Simplify clustermesh example #27172

merged 1 commit into from
Aug 2, 2023
+4 −4

Conversation

joestringer
Copy link
Member

The use of a /9 here as an example instead of the /8 was confusing
various users. Reuse the /8 instead.

@joestringer joestringer requested review from a team as code owners July 31, 2023 23:41
@joestringer joestringer added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.13 labels Jul 31, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jul 31, 2023
@joestringer
Copy link
Member Author

/test

learnitall
learnitall approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@learnitall learnitall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome looks good! One unrelated grammar nit that we could fix in this PR if you have time.

@maintainer-s-little-helper maintainer-s-little-helper bot added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. labels Aug 2, 2023
@joestringer
docs: Simplify clustermesh example

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
101732c 
The use of a /9 here as an example instead of the /8 was confusing
various users. Reuse the /8 instead.

Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer joestringer force-pushed the pr/joe/clustermesh-example branch from 3f2ef5e to 101732c Compare August 2, 2023 17:15
@joestringer
Copy link
Member Author

/test

@joestringer joestringer merged commit 8f4c98b into main Aug 2, 2023
@joestringer joestringer deleted the pr/joe/clustermesh-example branch August 2, 2023 18:00
@sayboras sayboras mentioned this pull request Aug 3, 2023
Merged
11 tasks
@sayboras sayboras added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 labels Aug 3, 2023
@sayboras sayboras mentioned this pull request Aug 3, 2023
Merged
4 tasks
@sayboras sayboras added backport-pending/1.13 backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed needs-backport/1.13 backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Aug 3, 2023
@sayboras sayboras added the backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. label Aug 4, 2023
This was referenced Aug 10, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YutaroHayakawa YutaroHayakawa

@learnitall learnitall

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
cilium v1.13.6
Status: Released
cilium v1.14.1
Status: Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joestringer @YutaroHayakawa @learnitall @sayboras