Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renovate: Don't exclude github.com/{cilium,vishvananda}/netlink anymore #27342

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

lambdanis
Copy link
Contributor

The netlink library was excluded from renovate updates in d6fe7de ("renovate: exclude github.com/{cilium,vishvananda}/netlink"), because at that point Cilium was using its fork, but then in 9f0be9e ("vendor: Update vishvananda/netlink/") it was switched back to the upstream version. Update the renovate configuration accordingly to no longer exclude netlink from updates.

The d6fe7de commit message says that it should be switched back, but it seems it hasn't been done yet. I think it needs to be backported to v1.14 too?

The netlink library was excluded from renovate updates in d6fe7de
("renovate: exclude github.com/{cilium,vishvananda}/netlink"), because at that
point Cilium was using its fork, but then in 9f0be9e ("vendor: Update
vishvananda/netlink/") it was switched back to the upstream version. Update the
renovate configuration accordingly to no longer exclude netlink from updates.

Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
@lambdanis lambdanis requested a review from tklauser August 8, 2023 10:25
@lambdanis lambdanis requested a review from a team as a code owner August 8, 2023 10:25
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 8, 2023
@lambdanis lambdanis added the release-note/misc This PR makes changes that have no direct user impact. label Aug 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 8, 2023
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Yeah, let's backport this to v1.14.

@lambdanis lambdanis added the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label Aug 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.1 Aug 8, 2023
@lambdanis
Copy link
Contributor Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 8, 2023
@tklauser tklauser merged commit d63d992 into cilium:main Aug 8, 2023
60 checks passed
@nebril nebril added this to Needs backport from main in 1.14.2 Aug 10, 2023
@nebril nebril removed this from Needs backport from main in 1.14.1 Aug 10, 2023
@tklauser tklauser mentioned this pull request Aug 22, 2023
22 tasks
@tklauser tklauser added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Aug 22, 2023
@joestringer joestringer added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Aug 25, 2023
@joestringer joestringer moved this from Needs backport from main to Backport done to v1.14 in 1.14.2 Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.14.2
Backport done to v1.14
Development

Successfully merging this pull request may close these issues.

None yet

3 participants