CI: Rename workflow names #27391
Merged
CI: Rename workflow names #27391
+120
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
brlbil
force-pushed
the
pr/brlbil/ci-rename-workflows
branch
from
d2df66a to
f94d984
Compare
brlbil
added
area/CI
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
gentoo-root
approved these changes
Aug 14, 2023
nbusseneau
reviewed
Aug 16, 2023
brlbil
force-pushed
the
pr/brlbil/ci-rename-workflows
branch
from
f94d984 to
5e69b54
Compare
nebril
approved these changes
Aug 18, 2023
aanm
approved these changes
Aug 24, 2023
This commit changes workflow's name fields to make them more human readable by adding spaces. Also some of the names was changed to be more consistent with each other Signed-off-by: Birol Bilgin <birol@cilium.io>
brlbil
force-pushed
the
pr/brlbil/ci-rename-workflows
branch
from
5e69b54 to
df0d946
Compare
|
/test |
|
Reviews in, failed tests are not related to the changes, setting as ready-to-merge |
brlbil
added
the
ready-to-merge
|
@brlbil @nbusseneau how do we ensure consistency over time for these? I would like to avoid making rename changes like this as much as possible in future due to the disruption to PRs (renaming => have to rebase and rerun CI for every PR). Every time we create a new CI job there is a risk that we'll deviate again and then later on end up submitting a change again. We are still periodically adding more CI jobs. Is this something that @cilium/ci-structure will now enforce? |
|
I think yes, the right way forward would be to be stricter when doing reviews. |
pippolo84
added
backport-pending/1.14
This was referenced Aug 31, 2023
Merged
michi-covalent
added
backport-done/1.14
michi-covalent
added
backport-done/1.13
michi-covalent
added
backport-done/1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the workflow's name fields to make them more human-readable by adding spaces.
Also, some of the names were changed to be more consistent with each other.