gha: fix waiting for images in conformance-gingko #27397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
added
area/CI
|
/ci-ginkgo |
Let's add an explicit dependency to the wait-for-images job, so that subsequent jobs are not started until the images are actually available. This also prevents starting the full matrix jobs if the images don't get ready in time. Finally, let's adapt status reporting, so that we properly report a failure in that case. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
pr/giorio94/conformance-ginkgo-wait-for-images
branch
from
84292bf
to
7096a5f
Compare
|
/ci-ginkgo |
giorio94
force-pushed
the
pr/giorio94/conformance-ginkgo-wait-for-images
branch
from
7096a5f
to
d37ec8d
Compare
|
/ci-ginkgo |
tklauser
approved these changes
Aug 9, 2023
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
tklauser
added
backport-pending/1.14
joestringer
added
backport-done/1.14
joestringer
moved this from Needs backport from main
to Backport done to v1.14
in 1.14.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's add an explicit dependency to the wait-for-images job, so that subsequent jobs are not started until the images are actually available. This also prevents starting the full matrix jobs if the images don't get ready in time.
Example run after the fix (with reduce timeout to trigger failure): https://github.com/cilium/cilium/actions/runs/5812104573/job/15756825851