Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update L7 traffic CiliumClusterwideEnvoyConfig example #27409

Merged
merged 1 commit into from
Aug 15, 2023
Merged

docs: update L7 traffic CiliumClusterwideEnvoyConfig example #27409

merged 1 commit into from
Aug 15, 2023

Conversation

tanjunchen
Copy link
Contributor

@tanjunchen tanjunchen commented Aug 10, 2023 •
edited by sayboras

Fixes: #27408

docs: update L7 traffic CiliumClusterwideEnvoyConfig example

@tanjunchen tanjunchen requested a review from a team as a code owner August 10, 2023 05:10
@maintainer-s-little-helper
Copy link

Commit 2c0804d8b4fef75f57b83936fe3e6385619d3022 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Aug 10, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Aug 10, 2023
@maintainer-s-little-helper
Copy link

Commit 3bccc16b374111e6abbbd8e748e21dc5172eadec does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Aug 10, 2023
@sayboras sayboras self-requested a review August 10, 2023 06:00
@maintainer-s-little-helper
Copy link

Commit 80fec4ce579ac77f762fb48b8d969990899f1e25 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. and removed dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. labels Aug 10, 2023
@maintainer-s-little-helper
Copy link

Commit 291b807dbcd1e66e73ffcf2bb2f19e71b3908388 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. and removed dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. labels Aug 11, 2023
@sayboras sayboras added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Aug 11, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 11, 2023
@sayboras sayboras changed the title update CiliumClusterwideEnvoyConfig for cilium docs: update L7 traffic CiliumClusterwideEnvoyConfig example Aug 11, 2023
sayboras
sayboras reviewed Aug 11, 2023
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, can you help to update other files in the same dir

  • envoy-admin-listener.yaml
  • envoy-prometheus-metrics-listener.yaml

Also, please add similar details in the commit message.

@tanjunchen
Copy link
Contributor Author

Thanks for your PR, can you help to update other files in the same dir

  • envoy-admin-listener.yaml
  • envoy-prometheus-metrics-listener.yaml

Also, please add similar details in the commit message.

done. @sayboras

sayboras
sayboras approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nitpick, the rest looks good to me. Thanks.

examples/kubernetes/servicemesh/envoy/envoy-admin-listener.yaml Outdated Show resolved Hide resolved
@sayboras sayboras added needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Aug 11, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.12.13 Aug 11, 2023
@sayboras
Copy link
Member

/test

@asauber asauber added this to Needs backport from main in 1.12.14 Aug 13, 2023
@asauber asauber removed this from Needs backport from main in 1.12.13 Aug 13, 2023
@tanjunchen
update L7 traffic CiliumClusterwideEnvoyConfig example
9832887 
Signed-off-by: chentanjun <tanjunchen20@gmail.com>
@tanjunchen
Copy link
Contributor Author

tanjunchen commented Aug 14, 2023 •
edited

/test

@sayboras can you review or merge this pr? thanks~

@tanjunchen
Copy link
Contributor Author

/test

1 similar comment
@sayboras
Copy link
Member

/test

@sayboras
Copy link
Member

Sorry for late reply, I was off a last few days.

@sayboras sayboras added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 15, 2023
@sayboras sayboras merged commit 0cd6932 into cilium:main Aug 15, 2023
59 checks passed
@tklauser tklauser mentioned this pull request Aug 22, 2023
Merged
22 tasks
@tklauser tklauser added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Aug 22, 2023
@tklauser tklauser mentioned this pull request Aug 23, 2023
Merged
8 tasks
@tklauser tklauser added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Aug 23, 2023
@tklauser tklauser mentioned this pull request Aug 23, 2023
Merged
7 tasks
@joestringer joestringer added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Aug 25, 2023
@tklauser tklauser added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Aug 25, 2023
@joestringer joestringer added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Aug 25, 2023
@joestringer joestringer moved this from Needs backport from main to Backport done to v1.12 in 1.12.14 Aug 25, 2023
This was referenced Sep 9, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayboras sayboras sayboras approved these changes

@joamaki joamaki Awaiting requested review from joamaki joamaki is a code owner automatically assigned from cilium/sig-k8s

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.12.14
Backport done to v1.12
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CiliumClusterwideEnvoyConfig deprecated for Envoy load balancing and URL rewriting
4 participants
@tanjunchen @sayboras @tklauser @joestringer