envoy: fix panic writing accesslog without L7 tags #27453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR cilium#24649 removed the deprecated support for adding fallback HTTP log tags if the access log entry wasn't of type HTTP, Kafka or GenericL7. This removal leads to panics when the l7Tags function (`nil`) is called while trying to enrich the log entry. Therefore, this commit changes the behaviour by defaulting to an noop l7Tags function if no specific L7 information are present. Fixes: cilium#27442 Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
added
kind/bug
|
/test |
mhofstetter
added
needs-backport/1.13
2 tasks
christarazi
approved these changes
Aug 14, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
2 tasks
tklauser
added
backport-pending/1.14
tklauser
added
backport-pending/1.13
joestringer
added
backport-done/1.13
This was referenced Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #24649 removed the deprecated support for adding fallback HTTP log tags if the access log entry wasn't of type HTTP, Kafka or GenericL7.
This removal leads to panics when the l7Tags function (
nil) is called while trying to enrich the log entry in cases where no L7 tags are available.Therefore, this commit changes the behaviour by defaulting to an noop l7Tags function if no specific L7 information are present.
Needs backport to v1.14 & v1.13 (#26722)
Fixes: #27442