Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Affinity in cilium-pre-flight-check daemonset #27475

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Fix: Affinity in cilium-pre-flight-check daemonset #27475

merged 1 commit into from
Aug 21, 2023

Conversation

ishuar
Copy link
Contributor

@ishuar ishuar commented Aug 13, 2023 •
edited

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!
Fix: Affinity in cilium-pre-flight-check daemonset.

@ishuar ishuar requested review from a team as code owners August 13, 2023 20:00
@ishuar ishuar requested review from joamaki and kaworu August 13, 2023 20:00
@maintainer-s-little-helper
Copy link

Commit cf00fda216a3e7654751eb60c4be0b3465410b36 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Aug 13, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Aug 13, 2023
@ishuar ishuar force-pushed the fix/missing-affinity-spec-cillium-preflight-check-daemonset branch from cf00fda to 10c0540 Compare August 13, 2023 20:00
@maintainer-s-little-helper
Copy link

Commit cf00fda216a3e7654751eb60c4be0b3465410b36 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@ishuar ishuar force-pushed the fix/missing-affinity-spec-cillium-preflight-check-daemonset branch from 10c0540 to a42f4ef Compare August 13, 2023 20:04
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Aug 13, 2023
@ishuar ishuar changed the title added affinity to cillium-preflight daemonset Fix: Affinity in cilium-pre-flight-check daemonset Aug 13, 2023
@ishuar ishuar force-pushed the fix/missing-affinity-spec-cillium-preflight-check-daemonset branch from a42f4ef to f57a417 Compare August 14, 2023 21:58
@joestringer joestringer added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Aug 15, 2023
@joestringer
Copy link
Member

/test

kaworu
kaworu approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@kaworu kaworu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ishuar ishuar force-pushed the fix/missing-affinity-spec-cillium-preflight-check-daemonset branch 2 times, most recently from 8a906d9 to 86e4db5 Compare August 16, 2023 17:25
@ishuar
Copy link
Contributor Author

ishuar commented Aug 16, 2023

@kaworu Is there anything needed from my side to get it merged?

@joamaki
Copy link
Contributor

joamaki commented Aug 17, 2023

/test

@ishuar
added affinity to cillium-preflight daemonset
868edc2 
Signed-off-by: ishuar <ishansharma887@gmail.com>
@ishuar ishuar force-pushed the fix/missing-affinity-spec-cillium-preflight-check-daemonset branch from 86e4db5 to 868edc2 Compare August 17, 2023 11:26
@joestringer
Copy link
Member

/test

@joestringer
Copy link
Member

The runtime failure is a known failure on the main branch #27080, unrelated to this PR. I'll re-run it to confirm.

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 17, 2023
@joestringer joestringer merged commit 8b9eff9 into cilium:main Aug 21, 2023
59 of 60 checks passed
@ishuar ishuar deleted the fix/missing-affinity-spec-cillium-preflight-check-daemonset branch August 21, 2023 21:42
@tklauser tklauser mentioned this pull request Aug 22, 2023
Merged
22 tasks
@tklauser tklauser added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Aug 22, 2023
@joestringer joestringer added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Aug 25, 2023
@michi-covalent michi-covalent mentioned this pull request Sep 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaworu kaworu kaworu approved these changes

@joamaki joamaki joamaki approved these changes

Assignees
No one assigned
Labels
backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing affinity in the preflight daemonset template
5 participants
@ishuar @joestringer @joamaki @kaworu @tklauser