docs: Correct comment on toFQDN API definition #27496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
joestringer
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
joestringer
approved these changes
Aug 15, 2023
joestringer
added
the
needs-backport/1.14
nathanjsweet
approved these changes
Aug 15, 2023
|
@joestringer are you able to trigger the CI tests? Unfortunately the CRD needed updating so these tests probably do need to be run. |
|
/test |
|
Could you squash the two commits together? Also the |
Alex-Waring
force-pushed
the
AWar_fqdn_doc
branch
from
ae19bc5
to
14c0ac6
Compare
The comment is 5 years old and no longer valid, removing and updating the CRD. Signed-off-by: Alex Waring <ajmwaring@gmail.com>
Alex-Waring
force-pushed
the
AWar_fqdn_doc
branch
from
14c0ac6
to
e81b757
Compare
|
Squashed and bowed to our bot overlords. |
|
/test |
|
@joestringer any idea what Travis is complaining about? |
|
It looks like Travis just timed out. The actual coverage Travis provides is also available in other jobs, Travis just runs on arm64 as well. There's no platform-specific issue here, I'm happy to merge this as-is. |
joestringer
approved these changes
Aug 18, 2023
|
Thanks for the contribution @Alex-Waring! |
tklauser
added
backport-pending/1.14
joestringer
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was added 5 years ago, and is no longer correct. Removing as discussed in slack conversation: https://cilium.slack.com/archives/C01JALNQAR1/p1692007243176749
This is a change in a comment to a file, so should need no release notes, or testing, just validation that the removal is correct.