Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add conn-disrupt-test action for reuse #27567

Merged

Conversation

jschwinger233
Copy link
Member

This commit makes conn-disrupt-test a github action, so upgrade test and IPsec key rotation test don't have to copy and paste everywhere.

The idea is to allow caller workflow to specify the commands to execute, then this action will follow the steps:

  1. Run "cilium-cli connectivity test --conn-disrupt-test-setup";
  2. Run whatever caller workflow passes: could be upgrade operation or IPsec key rotation;
  3. Run "cilium-cli connectivity test --include-conn-disrupt-test";

Signed-off-by: Zhichuan Liang gray.liang@isovalent.com

This commit makes conn-disrupt-test a github action, so upgrade test
and IPsec key rotation test don't have to copy and paste everywhere.

The idea is to allow caller workflow to specify the commands to execute,
then this action will follow the steps:
1. Run "cilium-cli connectivity test --conn-disrupt-test-setup";
2. Run whatever caller workflow passes: could be upgrade operation or
   IPsec key rotation;
3. Run "cilium-cli connectivity test --include-conn-disrupt-test";

Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 17, 2023
@jschwinger233 jschwinger233 added the release-note/ci This PR makes changes to the CI. label Aug 17, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Aug 17, 2023
@jschwinger233 jschwinger233 added area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Aug 17, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Aug 17, 2023
@jschwinger233 jschwinger233 added the sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. label Aug 17, 2023
@jschwinger233 jschwinger233 marked this pull request as ready for review August 17, 2023 12:40
@jschwinger233 jschwinger233 requested a review from a team as a code owner August 17, 2023 12:40
@brb brb self-requested a review August 19, 2023 08:11
@jschwinger233 jschwinger233 added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 22, 2023
@joestringer
Copy link
Member

@jschwinger233 @brb it looks like @brb was expecting to give a review, but you've set ready-to-merge. I have two concerns here: One, the baseline expectation to merge PRs is run CI plus codeowner reviews are in. CI is missing, though I understand this is a new github workflow. At the same time, the new CI should properly skip all unrelated jobs so we should get in the habit of always running CI and not trying to bypass or ignore it. Two, if @brb has plans to review then we should give him the opportunity to review it.

@joestringer joestringer removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 22, 2023
@joestringer
Copy link
Member

/test

Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pchaigno
Copy link
Member

I created #27647 for the flake affecting ConformanceGatewayAPI. It's clearly unrelated as the present PR only introduces a new GitHub Action (not even workflow) which isn't used anywhere yet. Marking ready to merge.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 23, 2023
@joestringer joestringer merged commit 48023b9 into cilium:main Aug 23, 2023
60 of 61 checks passed
@jschwinger233 jschwinger233 added needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Sep 25, 2023
@jschwinger233 jschwinger233 added the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label Sep 25, 2023
@giorio94 giorio94 mentioned this pull request Sep 26, 2023
22 tasks
@giorio94 giorio94 added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Sep 26, 2023
@giorio94 giorio94 mentioned this pull request Sep 26, 2023
12 tasks
@jschwinger233 jschwinger233 added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Sep 27, 2023
@aanm aanm added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. backport-pending/1.12 labels Sep 29, 2023
@julianwiedmann julianwiedmann added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants