Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set kvstoremesh image when pushing the development helm chart #27645

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Set kvstoremesh image when pushing the development helm chart #27645

merged 1 commit into from
Aug 23, 2023

Conversation

giorio94
Copy link
Member

@giorio94 giorio94 commented Aug 23, 2023 •
edited

Configure the kvstoremesh repository and tag to match the one of the other cilium components. Additionally, explicitly disable the digest, which is otherwise configured in stable branches.

Outcome with this change:

$ helm show values -n kube-system oci://quay.io/cilium-charts-dev/cilium \
      --version 1.15.0-dev-dev.725-pr-giorio94-main-gha-push-chart-kvstoremesh-3a6c2670f8 | \
      grep 'kvstoremesh:' -A12 -m 1

kvstoremesh:
  # -- Enable KVStoreMesh. KVStoreMesh caches the information retrieved
  # from the remote clusters in the local etcd instance.
  enabled: false
  # -- KVStoreMesh image.
  image:
    override: ~
    repository: "quay.io/cilium/kvstoremesh-ci"
    tag: "3a6c2670f89bbc8b9de6ebf69cae1aab4f9f2718"
    # kvstoremesh-digest
    digest: ""
    useDigest: false
    pullPolicy: "Always"

@giorio94 giorio94 added area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. release-note/ci This PR makes changes to the CI. needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Aug 23, 2023
@giorio94 giorio94 force-pushed the pr/giorio94/main/gha-push-chart-kvstoremesh branch 2 times, most recently from ba0a598 to 92c2366 Compare August 23, 2023 09:16
@giorio94 giorio94 marked this pull request as ready for review August 23, 2023 09:17
@giorio94 giorio94 requested review from a team as code owners August 23, 2023 09:17
@giorio94 giorio94 marked this pull request as draft August 23, 2023 09:22
@giorio94 giorio94 force-pushed the pr/giorio94/main/gha-push-chart-kvstoremesh branch 2 times, most recently from 69c2655 to 16c713e Compare August 23, 2023 09:29
@giorio94 giorio94 marked this pull request as ready for review August 23, 2023 09:33
@giorio94 giorio94 mentioned this pull request Aug 23, 2023
Merged
@giorio94 giorio94 force-pushed the pr/giorio94/main/gha-push-chart-kvstoremesh branch from 16c713e to e11ea06 Compare August 23, 2023 12:25
@giorio94
Copy link
Member Author

giorio94 commented Aug 23, 2023 •
edited

Last push was to fix a missing open quote an incorrect quote in the useDigest parameter.

@giorio94
gha: set kvstoremesh image when pushing the development helm chart
2e95574 
Configure the kvstoremesh repository and tag to match the one of the
other cilium components. Additionally, explicitly disable the digest,
which is otherwise configured in stable branches.

Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
@giorio94 giorio94 force-pushed the pr/giorio94/main/gha-push-chart-kvstoremesh branch 2 times, most recently from 3a6c267 to 2e95574 Compare August 23, 2023 12:44
@giorio94
Copy link
Member Author

I did one additional test after the fix, and the chart was rendered and installed correctly. I'm marking this PR ready to merge given that the review is in, and it only touches a GHA workflow.

@giorio94 giorio94 added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Aug 23, 2023
joestringer
joestringer requested changes Aug 23, 2023
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's resolve the discussion above first. Whether or not it makes sense to override the digest pieces, it should be consistent for all images, not different for the kvstoremesh.

@joestringer joestringer mentioned this pull request Aug 23, 2023
Closed
@joestringer
Copy link
Member

Filed #27675 for the test failure, it's clearly unrelated and seems like a bug in the metrics CI test.

@joestringer joestringer merged commit 6367398 into main Aug 23, 2023
79 of 84 checks passed
@joestringer joestringer deleted the pr/giorio94/main/gha-push-chart-kvstoremesh branch August 23, 2023 21:50
@tklauser tklauser mentioned this pull request Aug 24, 2023
Merged
9 tasks
@tklauser tklauser added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Aug 24, 2023
@joestringer joestringer added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Aug 25, 2023
@michi-covalent michi-covalent mentioned this pull request Sep 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@nbusseneau nbusseneau nbusseneau approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/clustermesh Relates to multi-cluster routing functionality in Cilium. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@giorio94 @joestringer @nbusseneau @tklauser