-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable the images digest when pushing the development helm chart #27646
Conversation
953bfe3
to
7349c70
Compare
7349c70
to
bd18f0f
Compare
This one also triggered #27675, I don't really understand why. Is it because the base commit is earlier in the tree and somehow the test is only running a diff vs. |
While the digests are unset and disabled in the main branch, they are set to the values corresponding to the latest patch release for stable branches. Hence, let's explicitly disable them when pushing the development helm chart. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
bd18f0f
to
0a51d4c
Compare
Thanks for opening the issue! To be honest it is unclear to me why this didn't also happen on the original PR introducing the metric. |
0a51d4c
to
2f59a89
Compare
Rebased onto main to fix a conflict, and re-tested |
/test |
Everything seems green. It's unclear to me why MLH didn't mark this as ready to merge. Doing that manually. |
I incorrectly though that this workflow had been backported to v1.12 and v1.13, but it appears not to exist in these branches. Hence, dropping the associated |
While the digests are unset and disabled in the main branch, they are set to the values corresponding to the latest patch release for stable branches. Hence, let's explicitly disable them when pushing the development helm chart.
Tested on top of the v1.14 branch (non-relevant images are omitted, the kvstoremesh image is configured in #27645, due to the different backport policy):