Fix bug when reusing the same cell in multiple hives #27873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
added
kind/bug
|
/test |
giorio94
force-pushed
the
pr/giorio94/main/hive-fix-reuse-same-cell
branch
from
3a850ab
to
b06793f
Compare
|
/test |
joamaki
approved these changes
Sep 11, 2023
joamaki
added
the
needs-backport/1.14
|
Even though there was nothing shipped in v1.14 that was affected by this bug, lets backport this before we backport code that could be affected. |
Currently, the "Invoke" cell internally stores a reference to the container when Apply() gets called. Yet, this causes issues if the same cell is registered as part of multiple hives (e.g., constructing multiple subcommands), as that reference gets overwritten by new hive.New() executions. Let's remove this explicit reference, capturing instead the container parameter through an anonymous function. Additionally, let's craft a unit test to prevent regressions. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
pr/giorio94/main/hive-fix-reuse-same-cell
branch
from
b06793f
to
d8e094a
Compare
|
Rebased onto main |
|
/test |
giorio94
added
backport-pending/1.14
aanm
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the "Invoke" cell internally stores a reference to the container when
Apply()gets called. Yet, this causes issues if the same cell is registered as part of multiple hives (e.g., constructing multiple subcommands), as that reference gets overwritten by newhive.New()executions.Let's remove this explicit reference, capturing instead the container parameter through an anonymous function. Additionally, let's craft a unit test to prevent regressions.