[v1.14] cilium: Fix 16bit ifindex limitation #27880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borkmann
added
sig/datapath
maintainer-s-little-helper
bot
added
the
kind/backports
[ upstream commit bd8b4d0 ] [ manual conflict resolution in kube_proxy_replacement.go and nodeport.h due to difference from upstream, the latter mainly in locations where we ifdef ct_state.ifindex ] The limitation exists mainly on old kernels where the fib lookup helper does not populate the outgoing ifindex. Only for this case we rely on the CT lookup stored ifindex which back then was added as a 16bit field due to limited padding space available. Nowadays this can be lifted after the big rework in #23884. We've seen users with high netdevice churn run into this limitation where the agent bails out. Apart from fixing the bleed, this can be further refined by not relying on the asm.FnRedirectPeer helper presence but by actually doing a runtime BPF program probe so that stable kernels can even be covered. Fixes: #16260 Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
[ upstream commit 323b4cb ] [ no conflicts ] Commit d1c362e1dd68 ("bpf: Always return target ifindex in bpf_fib_lookup") which HAVE_FIB_IFINDEX reflects is part of is 5.10+ kernels. Add the define to the complexity tests for 5.10 and net-next to better reflect real world. Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
borkmann
force-pushed
the
pr/v1.14-ifindex
branch
from
c932451
to
009d53d
Compare
|
/test-backport-1.14 |
|
Maybe just grab #27528 as well, to align things with upstream? |
Good point, will include it! Thanks! |
[ upstream commit 8331fab ] As part of handling inbound DSR-ed requests at the backend node, we create a CT entry. The relevant code originated from nodeport_lb*(), where we also set the CT entry's ifindex. There it is used by the LB to route replies by local / NAT backends back to the client via the ingress interface. But for DSR it makes little sense to track the ingress interface at the backend. It's how the backend would reach the LB, not the client. And it's perfectly fine to route replies to the client through a different interface. Remove this tracking for DSR connections. Note that it's currently unused, it was merely added to have fully populated CT entries in case the ifindex would have ever been needed. Signed-off-by: Julian Wiedmann <jwi@isovalent.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
|
/test-backport-1.14 |
julianwiedmann
added
the
ready-to-merge
maintainer-s-little-helper
bot
removed
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of: