workflows/ipsec: Add missing --flush-ct for key rotation
#27883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
kind/bug/CI
pchaigno
force-pushed
the
pr/pchaigno/fix-missing-flush-ct
branch
from
a832ed2
to
d56c972
Compare
viktor-kurchenko
approved these changes
Sep 1, 2023
Now that we cover the key rotations in the IPsec e2e tests, we are running the connectivity test suite twice. That means we can run in the usual bug where an existing CT entry is reused and leads to us sending traffic to the proxy when we shouldn't. Thus, we need to flush the CT entries at the end of the first test run, with --flush-ct. Fixes: de192de ("ci-ipsec-e2e: Add IPsec key rotation test") Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
pchaigno
force-pushed
the
pr/pchaigno/fix-missing-flush-ct
branch
from
d56c972
to
8f39d08
Compare
|
/test |
maintainer-s-little-helper
bot
added
ready-to-merge
This was referenced Sep 12, 2023
jschwinger233
added
needs-backport/1.12
needs-backport/1.13
julianwiedmann
added
backport-pending/1.12
backport-pending/1.13
github-actions
bot
added
backport-done/1.12
julianwiedmann
added
backport-done/1.13
This was referenced Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we cover the key rotations in the IPsec e2e tests, we are running the connectivity test suite twice. That means we can run in the usual bug where an existing CT entry is reused and leads to us sending traffic to the proxy when we shouldn't (cf. #17459).
Thus, we need to flush the CT entries at the end of the first test run, with
--flush-ct.Fixes: de192de ("ci-ipsec-e2e: Add IPsec key rotation test")