Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ginkgo: Remove K8sDatapathCustomCalls #27911

Merged
merged 1 commit into from
Sep 4, 2023
Merged

ginkgo: Remove K8sDatapathCustomCalls #27911

merged 1 commit into from
Sep 4, 2023

Conversation

brb
Copy link
Member

@brb brb commented Sep 4, 2023

Currently, the feature is not used, and its test is blocking the LVH upgrade [1][2]. Let's remove the test case. Once it is in use, we should rethink the testing approach (either implement as a BPF unit test, or an advanced CLI connectivity test).

[1]: #27599
[2]: #27688

Fix #27688

@brb brb added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Sep 4, 2023
@brb brb requested review from a team as code owners September 4, 2023 08:51
@brb brb requested review from brlbil, nebril and aanm September 4, 2023 08:51
@brb
Copy link
Member Author

brb commented Sep 4, 2023

/test-ginkgo

@brb brb added needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Sep 4, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.2 Sep 4, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.7 Sep 4, 2023
Currently, the feature is not used, and its test is blocking the LVH
upgrade [1][2]. Let's remove the test case. Once it is in use, we should
rethink the testing approach (either implement as a BPF unit test, or
an advanced CLI connectivity test).

[1]: #27599
[2]: #27688

Signed-off-by: Martynas Pumputis <m@lambda.lt>
.github/actions/ginkgo/main-focus.yaml Outdated Show resolved Hide resolved
@brb
Copy link
Member Author

brb commented Sep 4, 2023

/test-ginkgo

@brb
Copy link
Member Author

brb commented Sep 4, 2023

/ci-ginkgo

@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 4, 2023
@aanm aanm merged commit 0da3f7e into main Sep 4, 2023
106 checks passed
@aanm aanm deleted the pr/brb/ci-rm-custom-calls branch September 4, 2023 09:47
@jibi jibi mentioned this pull request Sep 4, 2023
10 tasks
@jibi jibi added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Sep 4, 2023
@michi-covalent michi-covalent added this to Needs backport from main in 1.14.3 Sep 9, 2023
@michi-covalent michi-covalent removed this from Needs backport from main in 1.14.2 Sep 9, 2023
@michi-covalent michi-covalent added this to Backport pending to v1.13 in 1.13.8 Sep 9, 2023
@michi-covalent michi-covalent removed this from Needs backport from main in 1.13.7 Sep 9, 2023
@michi-covalent michi-covalent added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Sep 9, 2023
@michi-covalent michi-covalent removed this from Backport pending to v1.13 in 1.13.8 Sep 9, 2023
@michi-covalent michi-covalent added this to Backport done to v1.13 in 1.13.7 Sep 9, 2023
@gandro gandro mentioned this pull request Sep 12, 2023
15 tasks
@gandro gandro added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Sep 12, 2023
@gandro gandro added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Sep 25, 2023
@jrajahalme jrajahalme moved this from Needs backport from main to Backport done to v1.14 in 1.14.3 Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.13.7
Backport done to v1.13
1.14.3
Backport done to v1.14
5 participants