Fix cilium panic when HttpRoute with missing port. #27959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
|
/cc @meyskens @sig-servicemesh Ready for review, PTAL. Thanks~ |
|
Thanks good find! Might it be worth also adding a operator check like https://github.com/cilium/cilium/blob/main/operator/pkg/gateway-api/routechecks/route_checks.go#L40 so we can alert the user the route is not valid? As far as I know it is not there yet. |
chaunceyjiang
force-pushed
the
panic
branch
2 times, most recently
from
e8596ff
to
8ca07ab
Compare
|
Commit 8ca07ab147f60713912e2e3ec538cb26a68031f8 does not match "(?m)^Signed-off-by:". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
chaunceyjiang
force-pushed
the
panic
branch
from
8ca07ab
to
c333d48
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
Must have port for Service reference Fixes: cilium#27956 Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com>
chaunceyjiang
force-pushed
the
panic
branch
from
c333d48
to
797207f
Compare
|
Hi, @meyskens Please take a look again. Thanks~ |
|
/test |
meyskens
approved these changes
Sep 14, 2023
meyskens
added
the
release-note/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
meyskens
added
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
meyskens
added
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
meyskens
added
the
needs-backport/1.14
maintainer-s-little-helper
bot
added
the
ready-to-merge
giorio94
added
backport-pending/1.14
aanm
added
backport-done/1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Must have port for Service reference
Fixes: #27956
Refer to https://github.com/cilium/cilium/blob/main/vendor/sigs.k8s.io/gateway-api/apis/v1beta1/object_reference_types.go#L95
Fixes: #issue-number