-
Notifications
You must be signed in to change notification settings - Fork 3.2k
envoy: Sync supported resources in CiliumEnvoyConfig #28272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These resources are enabled in cilum-proxy build, and can be used in CiliumEnvoyConfig directly, however, without related imported statements, Cilium agent will fail to marshal/unmarshal objects. Sample error ``` level=warning msg="Ignoring invalid CiliumEnvoyConfig JSON (proto:\u00a0(line 1:405): unable to resolve \"type.googleapis.com/envoy.extensions.filters.http.router.v3.Router\": \"not found\") ``` Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is mainly to get the changes from below PR. Relates: cilium/cilium#28272 Signed-off-by: Tam Mach <tam.mach@cilium.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vendor changes lgtm.
This is mainly to get the changes from below PR. Relates: cilium/cilium#28272 Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is mainly to get the changes from below PR. Relates: cilium/cilium#28272 Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is mainly to get the changes from below PR. Relates: cilium/cilium#28272 Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is mainly to get the changes from below PR. Relates: cilium/cilium#28272 Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is mainly to get the changes from below PR. Also, syncing up the replace directive statements from cilium/cilium as well. Relates: cilium/cilium#28272 Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is mainly to get the changes from below PR. Also, syncing up the replace directive statements from cilium/cilium as well. Relates: cilium/cilium#28272 Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is mainly to get the changes from below PR. Also, syncing up the replace directive statements from cilium/cilium as well. Relates: #28272 Signed-off-by: Tam Mach <tam.mach@cilium.io>
[ cherry-picked from cilium/cilium-cli repository ] This is mainly to get the changes from below PR. Also, syncing up the replace directive statements from cilium/cilium as well. Relates: #28272 Signed-off-by: Tam Mach <tam.mach@cilium.io>
[ cherry-picked from cilium/cilium-cli repository ] This is mainly to get the changes from below PR. Also, syncing up the replace directive statements from cilium/cilium as well. Relates: #28272 Signed-off-by: Tam Mach <tam.mach@cilium.io>
These resources are enabled in cilum-proxy build, and can be used in CiliumEnvoyConfig directly, however, without related imported statements, Cilium agent will fail to marshal/unmarshal objects.
Sample error