-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.14 backports 2023-10-02 #28349
Merged
Merged
v1.14 backports 2023-10-02 #28349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ upstream commit dde4722 ] - Improved description for tunnel, tunnelProtocol, routingMode flags to make it clearer for users to know the possible values. - Added deprecation note for the tunnel flag to be in line with the v1.14.0 release notes and cilium#24561. Signed-off-by: Philip Schmid <philip.schmid@isovalent.com> Signed-off-by: Tam Mach <tam.mach@cilium.io>
[ upstream commit 682038d ] Also, remove setting custom nameserver (cilium/little-vm-helper-images#186). Signed-off-by: Martynas Pumputis <m@lambda.lt> Signed-off-by: Tam Mach <tam.mach@cilium.io>
[ upstream commit cc56e70 ] These resources are enabled in cilum-proxy build, and can be used in CiliumEnvoyConfig directly, however, without related imported statements, Cilium agent will fail to marshal/unmarshal objects. Sample error ``` level=warning msg="Ignoring invalid CiliumEnvoyConfig JSON (proto:\u00a0(line 1:405): unable to resolve \"type.googleapis.com/envoy.extensions.filters.http.router.v3.Router\": \"not found\") ``` Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
added
kind/backports
This PR provides functionality previously merged into master.
backport/1.14
This PR represents a backport for Cilium 1.14.x of a PR that was merged to main.
labels
Oct 2, 2023
/test-backport-1.14 |
PhilipSchmid
approved these changes
Oct 2, 2023
brb
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Reviews are in, CI is superb, marking this ready to merge. |
sayboras
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Oct 3, 2023
aanm
approved these changes
Oct 3, 2023
maintainer-s-little-helper
bot
removed
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/1.14
This PR represents a backport for Cilium 1.14.x of a PR that was merged to main.
kind/backports
This PR provides functionality previously merged into master.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, you can update the PR labels via: