[v1.14] GHA: Add clustermesh upgrade and downgrade tests #28355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport the script to retrieve the previous Cilium version, originally introduced in d51a932 ("Clean up tests-ipsec-upgrade workflow"). Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
added
area/CI
maintainer-s-little-helper
bot
added
backport/1.14
giorio94
force-pushed
the
pr/giorio94/v1.14/gha-clustermesh-upgrade
branch
5 times, most recently
from
603040e
to
cc7bc5c
Compare
This commit introduces a new GitHub actions workflow which validates the Cilium upgrade and downgrade paths when clustermesh is enabled, ensuring that one minor version skew is correctly supported. More specifically, the test initially deploys a mixed version cluster mesh, with one cluster running Cilium from the tip of the previous stable branch, and the other the tip of the current stable branch. At this point, the first cluster is upgraded to the tip of the current stable branch, enabling kvstoremesh at the same time. Finally, the cluster is downgraded again to the tip of the previous stable branch, disabling kvstoremesh. We do not enable the connectivity disruption checks in this workflow, because Cilium versions older than 1.14 are currently affected by known issues causing possible brief connectivity distruption of cross-cluster traffic when the agents get restarted. To reduce the total amount of time required by this workflow, only a limited subset of tests is enabled, while the full suite is run in the conformance-clustermesh workflow. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
pr/giorio94/v1.14/gha-clustermesh-upgrade
branch
from
cc7bc5c
to
9f4efed
Compare
|
/ci-clustermesh |
giorio94
force-pushed
the
pr/giorio94/v1.14/gha-clustermesh-upgrade
branch
from
9f4efed
to
957e0b3
Compare
|
/ci-clustermesh |
ti-mo
approved these changes
Oct 5, 2023
brlbil
approved these changes
Oct 5, 2023
|
Reviews are in, marking as ready to merge, given that it touches only GHA workflows. |
giorio94
added
the
ready-to-merge
|
The workflow seems pretty stable, let's mark it for backport to earlier branches. |
giorio94
added
needs-backport/1.12
needs-backport/1.13
joamaki
added
backport-pending/1.13
github-actions
bot
added
backport-done/1.12
This was referenced Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new GitHub actions workflow which validates the Cilium upgrade and downgrade paths when clustermesh is enabled, ensuring that one minor version skew is correctly supported.
More specifically, the test initially deploys a mixed version cluster mesh, with one cluster running Cilium from the tip of the previous stable branch, and the other the tip of the current stable branch. At this point, the first cluster is upgraded to the tip of the current stable branch, enabling kvstoremesh at the same time. Finally, the cluster is downgraded again to the tip of the previous stable branch, disabling kvstoremesh.
We do not enable the connectivity disruption checks in this workflow, because Cilium versions older than 1.14 are currently affected by known issues causing possible brief connectivity distruption of cross-cluster traffic when the agents get restarted.
To reduce the total amount of time required by this workflow, only a limited subset of tests is enabled, while the full suite is run in the conformance-clustermesh workflow.
This is a stripped-down version of #27232, without the connectivity disruption checks.