-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not hardcode the AWS VPC CNI plugin version in the conformance-aws-cni GHA workflow #28392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
added
area/CI
Continuous Integration testing issue or flake
release-note/ci
This PR makes changes to the CI.
integration/cloud
Related to integration with cloud environments such as AKS, EKS, GKE, etc.
labels
Oct 4, 2023
/ci-awscni |
Currently, we are installing a fixed version of the AWS VPC CNI plugin version (i.e., v1.11) regardless of the Kubernetes version. Yet, this means that in certain cases we upgrade it, while in others we downgrade, it, introducing unnecessary churn. Let's instead use the default one that gets installed with the given k8s version. Specifically, for the k8s versions currently tested: * k8s: v1.23 - AWS VPC CNI: v1.10.4-eksbuild.1 * k8s: v1.24 - AWS VPC CNI: v1.11.4-eksbuild.1 * k8s: v1.25 - AWS VPC CNI: v1.12.2-eksbuild.1 * k8s: v1.26 - AWS VPC CNI: v1.12.5-eksbuild.2 * k8s: v1.27 - AWS VPC CNI: v1.12.6-eksbuild.2 Retrieved through: for MINOR in $(seq 23 27) do echo -n "k8s: v1.$MINOR - AWS VPC CNI: " aws eks describe-addon-versions --addon-name vpc-cni \ --kubernetes-version 1.$MINOR --output yaml | \ yq '.addons[].addonVersions[] | select(.compatibilities[].defaultVersion == true) | .addonVersion'; done Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
pr/giorio94/main/conformance-aws-cni-plugin
branch
from
October 4, 2023 08:55
efd202d
to
f31c6f8
Compare
giorio94
added
needs-backport/1.12
needs-backport/1.13
This PR / issue needs backporting to the v1.13 branch
needs-backport/1.14
This PR / issue needs backporting to the v1.14 branch
labels
Oct 4, 2023
nbusseneau
approved these changes
Oct 4, 2023
Marking as ready to merge, as the PR only touches a GHA workflow. |
giorio94
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Oct 4, 2023
sayboras
added
backport-pending/1.14
The backport for Cilium 1.14.x for this PR is in progress.
and removed
needs-backport/1.14
This PR / issue needs backporting to the v1.14 branch
labels
Oct 6, 2023
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.3
Oct 6, 2023
sayboras
added
backport-pending/1.13
The backport for Cilium 1.13.x for this PR is in progress.
and removed
needs-backport/1.13
This PR / issue needs backporting to the v1.13 branch
labels
Oct 6, 2023
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.13
in 1.13.8
Oct 6, 2023
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.12
in 1.12.15
Oct 6, 2023
github-actions
bot
added
backport-done/1.12
The backport for Cilium 1.12.x for this PR is done.
and removed
backport-pending/1.13
The backport for Cilium 1.13.x for this PR is in progress.
labels
Oct 6, 2023
github-actions
bot
added
the
backport-done/1.13
The backport for Cilium 1.13.x for this PR is done.
label
Oct 6, 2023
github-actions
bot
added
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
and removed
backport-pending/1.14
The backport for Cilium 1.14.x for this PR is in progress.
labels
Oct 9, 2023
This was referenced Oct 17, 2023
jrajahalme
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.3
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/CI
Continuous Integration testing issue or flake
backport-done/1.12
The backport for Cilium 1.12.x for this PR is done.
backport-done/1.13
The backport for Cilium 1.13.x for this PR is done.
backport-done/1.14
The backport for Cilium 1.14.x for this PR is done.
integration/cloud
Related to integration with cloud environments such as AKS, EKS, GKE, etc.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are installing a fixed version of the AWS VPC CNI plugin
version (i.e., v1.11) regardless of the Kubernetes version. Yet, this
means that in certain cases we upgrade it, while in others we downgrade,
it, introducing unnecessary churn.
Let's instead use the default one that gets installed with the given
k8s version. Specifically, for the k8s versions currently tested:
Retrieved through:
Link to successful run: https://github.com/cilium/cilium/actions/runs/6403302318