policy: Fix Unspecified Protocol Type #28703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the policy API documentation, if a protocol is not specified in a PortProtocol type its protocol is supposed to be presumed as "ANY". The policy package inconsistently enforces this logic. As a result, empty Protocol fields are validated as "ANY", but, in the actual rule logic that splits the "ANY" protocol into the supported protocol types, the comparison was made only to the actual "ANY" protocol constant. This is fixed with an L4Proto method `IsAny` that does both the constant and empty string comparison. Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
nathanjsweet
added
the
release-note/minor
nathanjsweet
added
needs-backport/1.12
needs-backport/1.13
|
/test |
aanm
approved these changes
Oct 20, 2023
christarazi
added
the
sig/policy
christarazi
approved these changes
Oct 23, 2023
maintainer-s-little-helper
bot
added
ready-to-merge
nathanjsweet
deleted the
pr/nathanjsweet/fix-unspecified-l4-protocol-type
branch
tklauser
added
backport-pending/1.14
This was referenced Oct 24, 2023
tklauser
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.4
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.13
in 1.13.9
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.12
in 1.12.16
tklauser
added
backport-done/1.14
maintainer-s-little-helper
bot
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.4
maintainer-s-little-helper
bot
moved this from Backport pending to v1.14
to Backport done to v1.14
in 1.14.4
tklauser
added
backport-done/1.13
julianwiedmann
added
backport-done/1.12
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.9
maintainer-s-little-helper
bot
moved this from Backport pending to v1.12
to Backport done to v1.12
in 1.12.16
This was referenced Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the policy API documentation, if a
protocol is not specified in a PortProtocol type its protocol is supposed to be presumed as "ANY". The
policy package inconsistently enforces this logic. As a result, empty Protocol fields are validated as "ANY", but in the actual rule logic that splits
the "ANY" protocol into the supported protocol
types, the comparison was made only to the actual
"ANY" protocol constant. This is fixed with the
L4Proto method
IsAnythat does both the constant and empty string comparison.Fixes: #28136