Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: disable envoy tracing in multi-pool workflow #28966

Merged
merged 1 commit into from
Nov 7, 2023
Merged

ci: disable envoy tracing in multi-pool workflow #28966

merged 1 commit into from
Nov 7, 2023

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Nov 3, 2023

The multi-pool workflow doesn't exercise envoy in particular and the verbose logs make it harder to analyze logs. Disable them.

@tklauser
ci: disable envoy tracing in multi-pool workflow
f4aa13b 
The multi-pool workflow doesn't exercise envoy in particular and the
verbose logs make it harder to analyze logs. Disable them.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. area/multipool Affects Multi-Pool IPAM labels Nov 3, 2023
@tklauser tklauser requested a review from gandro November 3, 2023 11:00
@tklauser tklauser requested review from a team as code owners November 3, 2023 11:00
@tklauser tklauser requested a review from brlbil November 3, 2023 11:00
@tklauser
Copy link
Member Author

tklauser commented Nov 3, 2023

/ci-multi-pool

brlbil
brlbil approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@brlbil brlbil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be backported to 1.14 as well.

@tklauser tklauser added the needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch label Nov 3, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.14.4 Nov 3, 2023
gandro
gandro approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tklauser
Copy link
Member Author

tklauser commented Nov 7, 2023

Reviews are in and the multi-pool workflow passed. This is the only CI workflow affected by this change, marking as ready to merge.

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 7, 2023
@squeed squeed merged commit 90ad1cd into main Nov 7, 2023
48 checks passed
@squeed squeed deleted the pr/tklauser/ci-multi-pool-disable-envoy-tracing branch November 7, 2023 09:43
@jibi jibi mentioned this pull request Nov 7, 2023
Merged
15 tasks
@jibi jibi added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Nov 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.4 Nov 7, 2023
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Nov 8, 2023
@thorn3r thorn3r mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@brlbil brlbil brlbil approved these changes

@sayboras sayboras sayboras approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/multipool Affects Multi-Pool IPAM backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.14.4
Backport pending to v1.14
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tklauser @gandro @brlbil @sayboras @jibi @squeed