[v1.14] Author Backport of 28382 (Metrics associated with a deleted node should not be reported) #28980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derailed
added
kind/backports
|
/test-backport-1.14 |
derailed
force-pushed
the
pr/v1.14-backport-2023-11-03
branch
from
5812b00
to
94e3914
Compare
christarazi
approved these changes
Nov 6, 2023
|
/test-backport-1.14 |
|
Conformance e2e failure looks like: #27762 |
…er reported. [ upstream commit e9f97cd ] When a node is deleted from a cluster, metrics associated with that node are still being exported to prometheus. Short of restarting the agent, we want to dynamically delete these metrics when a node is removed from the cluster. This PR ensures node_connectivity_status and node_connectivity_latency no longer report metrics for nodes that are no longer present on the cluster. Signed-off-by: Fernand Galiana <fernand.galiana@isovalent.com>
derailed
force-pushed
the
pr/v1.14-backport-2023-11-03
branch
from
94e3914
to
4c04114
Compare
|
/test-backport-1.14 |
squeed
approved these changes
Nov 8, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, you can update the PR labels via: