gha: additionally cover BPF masquerade in clustermesh E2E tests #30321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
added
area/CI
giorio94
force-pushed
the
pr/giorio94/main/gha-clustermesh-bpf-masquerade
branch
from
ce1c7e8
to
90db4a4
Compare
|
/ci-clustermesh |
giorio94
added
needs-backport/1.14
|
Opening for review to start gathering feedback. Marking as blocked as well, given that it depends on cilium/cilium-cli#2242. |
Currently, BPF masquerade was always disabled in the clustermesh E2E tests due to unintended interactions with Docker iptables rules breaking DNS resolution [1]. Instead, let's explicitly configure external upstream DNS servers for coredns, so that we can also enable this feature when KPR is enabled. While being there, let's also make the KPR setting explicit, instead of relying on the Cilium CLI configuration (which is based on whether the kube-proxy daemonset is present or not). [1]: #23283 Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
pr/giorio94/main/gha-clustermesh-bpf-masquerade
branch
from
90db4a4
to
cf6beef
Compare
|
Rebased onto main to drop the temporary commit, as a new version of the Cilium CLI has been released. |
giorio94
removed
the
dont-merge/blocked
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
julianwiedmann
deleted the
pr/giorio94/main/gha-clustermesh-bpf-masquerade
branch
nbusseneau
added
backport-pending/1.14
12 tasks
nbusseneau
added
backport-pending/1.15
github-actions
bot
added
backport-done/1.15
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.14
in 1.14.7
github-actions
bot
added
backport-done/1.14
This was referenced Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, BPF masquerade was always disabled in the clustermesh E2E tests due to unintended interactions with Docker iptables rules breaking DNS resolution [1]. Instead, let's explicitly configure external upstream DNS servers for coredns, so that we can also enable this feature when KPR is enabled.
While being there, let's also make the KPR setting explicit, instead of relying on the Cilium CLI configuration (which is based on whether the kube-proxy daemonset is present or not).
[1]: #23283