Fix failure in FuzzDenyPreferredInsert test
#30368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
christarazi
commented
Jan 23, 2024
christarazi
commented
- policy: De-dup logic for insertion in map state in addDependentOnEntry()
- policy: Initialize mapstate structures before insertion
The logic for Insert() was duplicated inside addDependentOnEntry(), so call Insert() instead of repeating the logic for insertion. Signed-off-by: Chris Tarazi <chris@isovalent.com>
This commit refactors the mapstate insertion code such that it ensures the underlying map is initialized before inserting. The idea is to prevent the following error message: ``` panic: assignment to entry in nil map ``` which was exposed by the FuzzDenyPreferredInsert fuzz test.[1] Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=63091 [1]: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=63091 Signed-off-by: Chris Tarazi <chris@isovalent.com>
christarazi
added
kind/bug
christarazi
changed the title
FuzzDenyPreferredInsert test
|
/test |
christarazi
added
the
needs-backport/1.15
|
cc @cilium/sig-policy |
nathanjsweet
approved these changes
Feb 1, 2024
12 tasks
nbusseneau
added
backport-pending/1.15
github-actions
bot
added
backport-done/1.15
michi-covalent
moved this from Needs backport from main
to Backport done to v1.15
in 1.15.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.