Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub upload-artifact action #30443

Merged
merged 2 commits into from
Jan 29, 2024
Merged

Update GitHub upload-artifact action #30443

merged 2 commits into from
Jan 29, 2024

Conversation

brlbil
Copy link
Contributor

@brlbil brlbil commented Jan 25, 2024 •
edited

This PR updates and migrates upload-artifact GitHub action version from v3.1.3 to v4.2.0

With version 4 artifacts are immutable so consequent uploads with the same artifact name fail.
The artifact's name changes to be unique. Also, to combine all artifacts merge-upload job is added.
This job downloads, merges, and uploads the merged artifact. All temporary artifacts are deleted.

Fixes: #30396

/test does not test scheduled workflow runs, scheduled workflow runs are run and the links are below

conformance-aks
conformance-aws-cni
conformance-eks
conformance-external-workloads
conformance-gke

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 25, 2024
@brlbil
Copy link
Contributor Author

brlbil commented Jan 25, 2024

/test

@brlbil brlbil added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. labels Jan 25, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jan 25, 2024
@brlbil
Copy link
Contributor Author

brlbil commented Jan 25, 2024

/ci-aks

@brlbil
Copy link
Contributor Author

brlbil commented Jan 25, 2024

/ci-awscni

@brlbil
Copy link
Contributor Author

brlbil commented Jan 25, 2024

/ci-eks

@brlbil
Copy link
Contributor Author

brlbil commented Jan 25, 2024

/ci-external-workloads

@brlbil
Copy link
Contributor Author

brlbil commented Jan 25, 2024

/ci-gke

@brlbil brlbil force-pushed the pr/brlbil/update-github-upload-artifact branch from 4895ec8 to 60db1a3 Compare January 25, 2024 15:57
@brlbil
Copy link
Contributor Author

brlbil commented Jan 25, 2024

/test

@brlbil brlbil marked this pull request as ready for review January 25, 2024 16:48
@brlbil brlbil requested review from a team as code owners January 25, 2024 16:48
@brlbil
Copy link
Contributor Author

brlbil commented Jan 25, 2024

Two failing tests also show the collection of cilium-sysdumps.

@brlbil brlbil force-pushed the pr/brlbil/update-github-upload-artifact branch from 60db1a3 to 9e2e4b4 Compare January 26, 2024 11:37
@brlbil
Copy link
Contributor Author

brlbil commented Jan 26, 2024

/test

@brlbil brlbil marked this pull request as draft January 26, 2024 12:16
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport done to v1.13 in 1.13.12 Jan 31, 2024
@joamaki joamaki mentioned this pull request Jan 31, 2024
Merged
17 tasks
@joamaki joamaki added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels Jan 31, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.14 in 1.14.7 Jan 31, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport done to v1.13 in 1.13.12 Jan 31, 2024
@aanm aanm added this to Needs backport from main in 1.15.1 Jan 31, 2024
@aanm aanm removed this from Needs backport from main in v1.15.0-rc.1 Jan 31, 2024
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. and removed backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels Feb 7, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.14 in 1.14.7 Feb 7, 2024
@nbusseneau nbusseneau mentioned this pull request Feb 8, 2024
Merged
12 tasks
@nbusseneau nbusseneau added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Feb 8, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport done to v1.14 in 1.14.7 Feb 8, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Feb 9, 2024
This was referenced Feb 13, 2024
Merged
Merged
@michi-covalent michi-covalent moved this from Needs backport from main to Backport done to v1.15 in 1.15.1 Feb 14, 2024
@michi-covalent michi-covalent mentioned this pull request Feb 14, 2024
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.12.19 Feb 27, 2024
@julianwiedmann julianwiedmann mentioned this pull request Feb 27, 2024
Closed
@pippolo84 pippolo84 added the backport/author The backport will be carried out by the author of the PR. label Mar 5, 2024
@pippolo84
Copy link
Member

@brlbil just a heads up that I was unable to backport this to v1.12 because of the conflicts, so I added the backport-author label.

@brlbil brlbil mentioned this pull request Mar 7, 2024
Merged
@julianwiedmann julianwiedmann added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed needs-backport/1.12 labels Mar 14, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport done to v1.12 in 1.12.19 Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

@aanm aanm aanm approved these changes

@meyskens meyskens Awaiting requested review from meyskens meyskens is a code owner automatically assigned from cilium/sig-servicemesh

@pchaigno pchaigno Awaiting requested review from pchaigno pchaigno is a code owner automatically assigned from cilium/ipsec

@YutaroHayakawa YutaroHayakawa Awaiting requested review from YutaroHayakawa YutaroHayakawa is a code owner automatically assigned from cilium/sig-clustermesh

Assignees
No one assigned
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow backport/author The backport will be carried out by the author of the PR. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.12.19
Backport done to v1.12
1.13.12
Backport done to v1.13
1.14.7
Backport done to v1.14
1.15.1
Backport done to v1.15
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update upload-artifacts GitHub action to v4
7 participants
@brlbil @pippolo84 @christarazi @aanm @joamaki @nbusseneau @julianwiedmann