ci: Fix PR labels parsing in update label workflow #30507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github.event.pull_request.labels contains an array of objects that
describe various attributes of each label attached to the PR.
An example is the following from the GitHub docs:
"labels": [
{
"id": 208045946,
"node_id": "MDU6TGFiZWwyMDgwNDU5NDY=",
"url": "https://api.github.com/repos/octocat/Hello-World/labels/bug",
"name": "bug",
"description": "Something isn't working",
"color": "f29513",
"default": true
}
]
(see
https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#get-a-pull-request)
Being a JSON object, we cannot collect all the names of the labels in a
list with a '*' wildcard. Instead, the commit fixes the workflow first
copying the labels JSON array in an env variable and then using jq to
get all the labels names.
Fixes: 7fc78e9 ("ci: Add a call to the update label backport action")
Signed-off-by: Fabio Falzoi <fabio.falzoi@isovalent.com>
pippolo84
added
kind/bug/CI
|
/cc @giorio94 |
|
Tested in a mock repository (example run triggered by a |
christarazi
approved these changes
Jan 29, 2024
aanm
approved these changes
Jan 31, 2024
12 tasks
nbusseneau
added
backport-pending/1.15
github-actions
bot
added
backport-done/1.15
michi-covalent
moved this from Needs backport from main
to Backport done to v1.15
in 1.15.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.event.pull_request.labelscontains an array of objects that describe various attributes of each label attached to the PR.An example is the following from the GitHub docs:
(see
https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#get-a-pull-request)
Being a JSON object, we cannot collect all the names of the labels in a list with a '*' wildcard. Instead, the commit fixes the workflow first copying the labels JSON array in an env variable and then using
jqto get all the labels names.Fixes: 7fc78e9 ("ci: Add a call to the update label backport action")
Once backported to v1.15, this should fix errors in the workflow like this one: https://github.com/cilium/cilium/actions/runs/7637627812