Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpv1: remove BGP Controller from daemon cell #30561

Merged

Conversation

harsimran-pabla
Copy link
Contributor

@harsimran-pabla harsimran-pabla commented Jan 31, 2024

Remove BGP controller from daemon cell. Move BGP APIs to bgpv1 package.

@harsimran-pabla harsimran-pabla added release-note/misc This PR makes changes that have no direct user impact. area/bgp labels Jan 31, 2024
Copy link
Contributor

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice cleanup!

@harsimran-pabla harsimran-pabla added the needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch label Feb 1, 2024
@harsimran-pabla harsimran-pabla marked this pull request as ready for review February 1, 2024 15:07
@harsimran-pabla harsimran-pabla requested review from a team as code owners February 1, 2024 15:07
@harsimran-pabla
Copy link
Contributor Author

/test

pkg/bgpv1/agent/controller.go Outdated Show resolved Hide resolved
@harsimran-pabla harsimran-pabla force-pushed the hpabla/bgp/daemon-ref-cleanup branch 2 times, most recently from 5adebad to d7ac3d9 Compare February 9, 2024 12:47
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@harsimran-pabla
Copy link
Contributor Author

/test

@harsimran-pabla
Copy link
Contributor Author

L4LB CI failure: #30707

@harsimran-pabla
Copy link
Contributor Author

/test

Moved BGP rest APIs from daemon package to bgpv2 sub-system. This allows
us to remove references of BGP control plane from daemon.

Signed-off-by: harsimran pabla <hpabla@isovalent.com>
@harsimran-pabla
Copy link
Contributor Author

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 12, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.15.1 Feb 12, 2024
@YutaroHayakawa YutaroHayakawa added this pull request to the merge queue Feb 13, 2024
Merged via the queue into cilium:main with commit 51b4308 Feb 13, 2024
62 checks passed
@michi-covalent michi-covalent mentioned this pull request Feb 14, 2024
5 tasks
@michi-covalent michi-covalent added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels Feb 14, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.15 in 1.15.1 Feb 14, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. labels Feb 14, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed this from Backport pending to v1.15 in 1.15.1 Feb 14, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport done to v1.15 in 1.15.1 Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bgp backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.15.1
Backport done to v1.15
Development

Successfully merging this pull request may close these issues.

None yet

5 participants