-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgpv1: remove BGP Controller from daemon cell #30561
Merged
YutaroHayakawa
merged 1 commit into
cilium:main
from
harsimran-pabla:hpabla/bgp/daemon-ref-cleanup
Feb 13, 2024
Merged
bgpv1: remove BGP Controller from daemon cell #30561
YutaroHayakawa
merged 1 commit into
cilium:main
from
harsimran-pabla:hpabla/bgp/daemon-ref-cleanup
Feb 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsimran-pabla
added
release-note/misc
This PR makes changes that have no direct user impact.
area/bgp
labels
Jan 31, 2024
rastislavs
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice cleanup!
harsimran-pabla
added
the
needs-backport/1.15
This PR / issue needs backporting to the v1.15 branch
label
Feb 1, 2024
harsimran-pabla
force-pushed
the
hpabla/bgp/daemon-ref-cleanup
branch
from
February 1, 2024 15:06
eccc00c
to
7928407
Compare
harsimran-pabla
force-pushed
the
hpabla/bgp/daemon-ref-cleanup
branch
from
February 1, 2024 15:24
7928407
to
e3b954a
Compare
rastislavs
approved these changes
Feb 1, 2024
/test |
YutaroHayakawa
requested changes
Feb 2, 2024
harsimran-pabla
force-pushed
the
hpabla/bgp/daemon-ref-cleanup
branch
2 times, most recently
from
February 9, 2024 12:47
5adebad
to
d7ac3d9
Compare
ldelossa
approved these changes
Feb 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
YutaroHayakawa
approved these changes
Feb 12, 2024
/test |
L4LB CI failure: #30707 |
harsimran-pabla
force-pushed
the
hpabla/bgp/daemon-ref-cleanup
branch
from
February 12, 2024 08:41
d7ac3d9
to
226a48e
Compare
/test |
Moved BGP rest APIs from daemon package to bgpv2 sub-system. This allows us to remove references of BGP control plane from daemon. Signed-off-by: harsimran pabla <hpabla@isovalent.com>
harsimran-pabla
force-pushed
the
hpabla/bgp/daemon-ref-cleanup
branch
from
February 12, 2024 13:22
226a48e
to
aec20c8
Compare
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Feb 12, 2024
5 tasks
michi-covalent
added
backport-pending/1.15
The backport for Cilium 1.15.x for this PR is in progress.
and removed
needs-backport/1.15
This PR / issue needs backporting to the v1.15 branch
labels
Feb 14, 2024
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.15
in 1.15.1
Feb 14, 2024
github-actions
bot
added
backport-done/1.15
The backport for Cilium 1.15.x for this PR is done.
and removed
backport-pending/1.15
The backport for Cilium 1.15.x for this PR is in progress.
labels
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/bgp
backport-done/1.15
The backport for Cilium 1.15.x for this PR is done.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove BGP controller from daemon cell. Move BGP APIs to bgpv1 package.