egressgw: improvements for FIB-driven redirect path #30576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianwiedmann
added
sig/datapath
|
/test |
julianwiedmann
changed the title
julianwiedmann
commented
Feb 1, 2024
jibi
approved these changes
Feb 2, 2024
On kernels without HAVE_FIB_IFINDEX, we need to consider that a FIB lookup
with BPF_FIB_LKUP_RET_NO_NEIGH doesn't return a valid fib_params.l.ifindex
(see d1c362e1dd68 ("bpf: Always return target ifindex in bpf_fib_lookup")).
Instead:
- for the redirect in to-netdev, we exit on the current interface.
- for the redirect in from-overlay, we route via the stack.
Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
When the FIB lookup in to-netdev returns the same ifindex as the current interface, we want to skip the redirect. But that doesn't apply for the lookup in from-overlay - here we *always* need to redirect to the selected interface. As we previously handled the !is_defined(HAVE_FIB_IFINDEX) case, we can pass oif = 0 and trust that fib_do_redirect() will always use the ifindex from the fib_params. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
force-pushed
the
1.16-bpf-egressgw-fib
branch
from
2c51bfb
to
8b52869
Compare
|
/test |
ysksuzuki
approved these changes
Feb 5, 2024
maintainer-s-little-helper
bot
added
the
ready-to-merge
12 tasks
nbusseneau
added
backport-pending/1.15
github-actions
bot
removed
the
backport-pending/1.15
github-actions
bot
added
the
backport-done/1.15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iron out a few corner-cases in the new BPF-redirect logic for egressgw. This follows #26215 and #29379.